IndexOutOfBoundsException on draw (possibly related to #222530458) [235588730]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Jun 13, 2022 04:02PM

Jetpack Compose version: 1.2.0-beta03
Jetpack Compose component used: BottomSheetScaffold, LazyVerticalGrid, Navigation
Android Studio Build: AI-212.5712.43.2112.8512546
Kotlin version: 1.6.21

Clicking an item in a LazyVerticalGrid navigates to the next screen, which opens a BottomSheetScaffold and crashes immediately thereafter.
Issue does not occur on Compose 1.1.0 and Kotlin 1.6.10, or prior.

Stack trace (if applicable):
Fatal Exception: java.lang.IndexOutOfBoundsException: Index 0 is out of bounds. The list has 0 elements.
at androidx.compose.runtime.collection.MutableVectorKt.checkIndex(MutableVector.kt:1135)
at androidx.compose.runtime.collection.MutableVectorKt.access$checkIndex(MutableVector.kt:1)
at androidx.compose.runtime.collection.MutableVector$MutableVectorList.get(MutableVector.kt:940)
at androidx.compose.material.BottomSheetScaffoldKt$BottomSheetScaffoldLayout$1$1.invoke-0kLqBqw(BottomSheetScaffold.kt:452)
at androidx.compose.material.BottomSheetScaffoldKt$BottomSheetScaffoldLayout$1$1.invoke(BottomSheetScaffold.kt:430)
at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:590)
at androidx.compose.ui.node.InnerPlaceable.measure-BRTryo0(InnerPlaceable.kt:44)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1428)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1427)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2099)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:112)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:78)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:66)
at androidx.compose.ui.node.LayoutNode.performMeasure-BRTryo0$ui_release(LayoutNode.kt:1427)
at androidx.compose.ui.node.OuterMeasurablePlaceable.remeasure-BRTryo0(OuterMeasurablePlaceable.kt:94)
at androidx.compose.ui.node.OuterMeasurablePlaceable.measure-BRTryo0(OuterMeasurablePlaceable.kt:75)
at androidx.compose.ui.node.LayoutNode.measure-BRTryo0(LayoutNode.kt:1366)
at androidx.compose.foundation.layout.BoxKt$boxMeasurePolicy$1.measure-3p2s80s(Box.kt:115)
at androidx.compose.ui.node.InnerPlaceable.measure-BRTryo0(InnerPlaceable.kt:44)
at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:405)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.foundation.layout.FillModifier.measure-3p2s80s(Size.kt:658)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1428)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1427)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2099)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:112)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:78)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:66)
at androidx.compose.ui.node.LayoutNode.performMeasure-BRTryo0$ui_release(LayoutNode.kt:1427)
at androidx.compose.ui.node.OuterMeasurablePlaceable.remeasure-BRTryo0(OuterMeasurablePlaceable.kt:94)
at androidx.compose.ui.node.OuterMeasurablePlaceable.measure-BRTryo0(OuterMeasurablePlaceable.kt:75)
at androidx.compose.ui.node.LayoutNode.measure-BRTryo0(LayoutNode.kt:1366)
at androidx.compose.animation.AnimatedEnterExitMeasurePolicy.measure-3p2s80s(AnimatedVisibility.kt:793)
at androidx.compose.ui.node.InnerPlaceable.measure-BRTryo0(InnerPlaceable.kt:44)
at androidx.compose.animation.SlideModifier.measure-3p2s80s(EnterExitTransition.kt:988)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.animation.AnimatedContentKt$AnimatedContent$5$1$1.invoke-3p2s80s(AnimatedContent.kt:643)
at androidx.compose.animation.AnimatedContentKt$AnimatedContent$5$1$1.invoke(AnimatedContent.kt:642)
at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:283)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1428)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1427)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2099)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:112)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:78)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:66)
at androidx.compose.ui.node.LayoutNode.performMeasure-BRTryo0$ui_release(LayoutNode.kt:1427)
at androidx.compose.ui.node.OuterMeasurablePlaceable.remeasure-BRTryo0(OuterMeasurablePlaceable.kt:94)
at androidx.compose.ui.node.OuterMeasurablePlaceable.measure-BRTryo0(OuterMeasurablePlaceable.kt:75)
at androidx.compose.ui.node.LayoutNode.measure-BRTryo0(LayoutNode.kt:1366)
at androidx.compose.animation.AnimatedContentMeasurePolicy.measure-3p2s80s(AnimatedContent.kt:689)
at androidx.compose.ui.node.InnerPlaceable.measure-BRTryo0(InnerPlaceable.kt:44)
at androidx.compose.animation.AnimatedContentScope$SizeModifier.measure-3p2s80s(AnimatedContent.kt:503)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:405)
at androidx.compose.ui.node.ModifiedLayoutNode.measure-BRTryo0(ModifiedLayoutNode.kt:53)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1428)
at androidx.compose.ui.node.LayoutNode$performMeasure$1.invoke(LayoutNode.kt:1427)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2099)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:112)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:78)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:66)
at androidx.compose.ui.node.LayoutNode.performMeasure-BRTryo0$ui_release(LayoutNode.kt:1427)
at androidx.compose.ui.node.OuterMeasurablePlaceable.remeasure-BRTryo0(OuterMeasurablePlaceable.kt:94)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1381)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release$default(LayoutNode.kt:1372)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:187)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:274)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.access$remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:38)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout(MeasureAndLayoutDelegate.kt:208)
at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout(AndroidComposeView.android.kt:752)
at androidx.compose.ui.node.Owner$DefaultImpls.measureAndLayout$default(Owner.kt:196)
at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:949)
at android.view.View.draw(View.java:22647)
at android.view.View.updateDisplayListIfDirty(View.java:21519)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
at android.view.View.updateDisplayListIfDirty(View.java:21475)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
at android.view.View.updateDisplayListIfDirty(View.java:21475)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
at android.view.View.updateDisplayListIfDirty(View.java:21475)
at android.view.ViewGroup.recreateChildDisplayList(ViewGroup.java:4512)
at android.view.ViewGroup.dispatchGetDisplayList(ViewGroup.java:4485)
at android.view.View.updateDisplayListIfDirty(View.java:21475)
at android.view.ThreadedRenderer.updateViewTreeDisplayList(ThreadedRenderer.java:534)
at android.view.ThreadedRenderer.updateRootDisplayList(ThreadedRenderer.java:540)
at android.view.ThreadedRenderer.draw(ThreadedRenderer.java:616)
at android.view.ViewRootImpl.draw(ViewRootImpl.java:4421)
at android.view.ViewRootImpl.performDraw(ViewRootImpl.java:4149)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:3309)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2126)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8653)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
at android.view.Choreographer.doCallbacks(Choreographer.java:845)
at android.view.Choreographer.doFrame(Choreographer.java:780)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7839)
at java.lang.reflect.Method.invoke(Method.java)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Comments

ma...@google.com <ma...@google.com> #2Jun 15, 2022 11:35AM

Assigned to jo...@google.com.

+cc Siyamed and Matvei

For the context, there've been this bug b/155211005 that also proposed to have a String overload for the foundation text field. This bug is marked as fixed. So I'm wondering whether we did not provide this primitive override on purpose.
Since we're considering merging the BaseTextField and CoreTextField, do we want to have the primitive override in a single 'core' text field?

jo...@gmail.com <jo...@gmail.com> #3Jun 15, 2022 02:40PM

do we want to have the primitive override in a single 'core' text field

I don't think so. This whole bug is a side effect of the naming problem we've already fixed. I would suggest to close this bug as fixed because of renaming and original problem being infeasible anymore.

If someone is reimplementing their TextField for their design need, I expect them to be ok with TextFieldValue hoisting or them be able to wrap this API with their string overload.

It seems reasonable to separate selection range and value long term, but maybe I'm missing some cases there where this might not work. Over to Siyamed to give some input here

lu...@minm.co <lu...@minm.co> #4Jun 17, 2022 12:52PM

I'm not actually sure that the Material TextFields fully replace this API – it's pretty common to need text input in various contexts that aren't well supported by the styling of a material TextField.

In particular, the label is often undesired in interactive inputs (search fields / inline data entry) and typical applications will need to use BaseTextField in typical application coding.

jo...@google.com <jo...@google.com> #5Jun 21, 2022 11:58AM

I'm currently working on a TODO sample app and am copy/pasting the code from TextField to manage state into the sample. I can't use either of the material text fields in this UI location.

@OptIn(ExperimentalFoundationApi::class)
@Composable
fun TodoTextField(value: String, onValueChange: (String) -> Unit, modifier: Modifier = Modifier) {
    // this code is used to manage the selection and composition state of the BaseTextField
    var textFieldValue by state { TextFieldValue() }
    if (textFieldValue.text != value) {
        @OptIn(InternalTextApi::class)
        textFieldValue = TextFieldValue(
            text = value,
            selection = textFieldValue.selection.constrain(0, value.length)
        )
    }
    BaseTextField(
        value = textFieldValue,
        onValueChange = {
            val previousValue = textFieldValue.text
            textFieldValue = it
            if (previousValue != it.text) {
                onValueChange(it.text)
            }
        },
        modifier = modifier
    )
}

It seems in general if we find that a material component requires an API like this for usability the core equivalent should be exposed similarly.

jo...@gmail.com <jo...@gmail.com> #6Jun 23, 2022 02:10PM

One thought is that maybe the label parameter should be optional in material text fields? Even though you can do label = {}, but label parameter being non-optional maybe makes it confusing.

vi...@asseco-see.hr <vi...@asseco-see.hr> #7Jul 1, 2022 08:06AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9e43642ea25a9c3f3a63cc7ddd6ef7eafc6348f0
Author: Anastasia Soboleva <soboleva@google.com>
Date: Wed Aug 12 10:10:17 2020

Make placeholder animated and label optional

Before this change label was a required slot API. But often label is not needed, and having it non-optional sends a wrong signal. With this change label is optional similar to other slots inside material text fields.

Placeholder animates on focus/unfocus as per MD specs.

Test: material tests passed + checked the demo
Fixes: 161519460
Bug: 162234081
Relnote: "Label became an optional parameter inside TextField and OutlinedTextField"
Change-Id: I267f6ada96a3371aaa99bdaa4007229ab7efddab

M compose/material/material/api/current.txt
M compose/material/material/api/public_plus_experimental_current.txt
M compose/material/material/api/restricted_current.txt
M compose/material/material/samples/src/main/java/androidx/compose/material/samples/TextFieldSamples.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt

https://android-review.googlesource.com/1398697

de...@evollu.com <de...@evollu.com> #8Jul 6, 2022 08:47AM

Assigning to Anastasia for future work or to close

Message last modified on Jul 6, 2022 08:53AM

gr...@gmail.com <gr...@gmail.com> #9Jul 7, 2022 04:54PM

We now provide both String and TextFieldValue overrides in both material and foundation text fields.

ap...@google.com <ap...@google.com> #10Jul 18, 2022 11:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit a4e112a7e234e77ffe195d652df9be709715c1dd
Author: Jossi Wolf <jossiwolf@google.com>
Date: Sun Jul 17 10:07:35 2022

Revert "Draw order & Snackbar placement for BottomSheetScaffold"

Revert submission 2104343-bs-elevation

Reason for revert: Submission caused multiple issues not caught by tests. Will revert for the time being and follow up with new Swipeable APIs.
Reverted Changes:
I069175ab5:Add golden for BottomSheetScaffoldScreenshotTest
Ia80b5d1eb:Draw order & Snackbar placement for BottomSheetScaffold

Bug:

b/235588730

Relnote: Reverted a change that surfaced issues with BottomSheetScaffold.

Change-Id: Iab650133cd45e1e2b9fbc2df9338d77956d52c21

D compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldScreenshotTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt

https://android-review.googlesource.com/2154074

al...@aboutobjects.com <al...@aboutobjects.com> #11Mar 24, 2023 12:05AM

This seems to have come back with Compose 1.4.0. I have to ensure that both the fab and body of BottomSheetScaffold have measurable content to avoid the IndexOutOfBounds.

jo...@google.com <jo...@google.com> #12Mar 24, 2023 05:42PM

Thanks, we're investigating this. (Fwiw, as a best practice you should do this anyway for the FAB)

ap...@google.com <ap...@google.com> #13Mar 24, 2023 07:20PM

Project: platform/frameworks/support
Branch: androidx-main

commit 524a9102fef1439b4c5a0d202da95b3a59034d40
Author: Jossi Wolf <jossiwolf@google.com>
Date: Fri Mar 24 16:30:21 2023

[M2] Layout all children of BottomSheetScaffold

Test: bottomSheetScaffold_emptySlots
Relnote: Fixed a bug where BottomSheetScaffold would crash when provided with empty content for slots.
Bug:

b/235588730

Change-Id: Ib24a55cf43d4e887f7742691e522d7fc843ce89c

M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomSheetScaffoldTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomSheetScaffold.kt

https://android-review.googlesource.com/2505860

jo...@google.com <jo...@google.com> #14Mar 24, 2023 08:03PM

Marked as fixed.

We will comment on this issue when the fix has been released.

na...@google.com <na...@google.com> #15Apr 5, 2023 06:28PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material:material:1.5.0-alpha02

al...@gmail.com <al...@gmail.com> #16Apr 13, 2023 01:13AM

My team was experiencing this as well. We just upgraded to Compose BoM 2023.03.00 and Kotlin 1.8.10.

For anyone using the Compose BoM for dependencies, you can supply the above alpha version to the dependency and it should override the supplied version in the BoM:

implementation platform("androidx.compose:compose-bom:2023.03.00")

implementation "androidx.compose.ui:ui"
implementation "androidx.compose.foundation:foundation"
// ...
// more deps
// ...
implementation "androidx.compose.material:material:1.5.0-alpha02"

This fixed the problem for us.

ja...@ackee.cz <ja...@ackee.cz> #17May 10, 2023 11:12AM

Crashes in Compose BOM 2023.05.00, Kotlin 1.8.10 and the Compose compiler 1.4.6.

Using implementation "androidx.compose.material:material:1.5.0-alpha03" resolved the issue.