[Material 3] Add nullable onClick to Chips [235792432]

Fixed

Bug

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

Jun 13, 2022 11:38AM

The documentation for chips says

onClick - called when this chip is clicked. If null, then this chip will not be interactable,
unless something else handles its input events and updates its state.

but the onClick parameter has a non-null Type

Because it isn't optional it always captures click events which isn't useful for example if a wrapping component is interactable or if you want to implement a custom click handler

Comments

co...@google.com <co...@google.com> #2Jun 13, 2022 05:42PM

Reassigned to ma...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

co...@google.com <co...@google.com> Jun 14, 2022 02:41PM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> #3Jun 15, 2022 12:31AM

Accepted by sg...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ap...@google.com <ap...@google.com> #4Jun 16, 2022 11:04PM

Project: platform/frameworks/support
Branch: androidx-main

commit 6dd2c85575fc0e9a361410f88e74a7d8898c0682
Author: Shalom Gibly <sgibly@google.com>
Date: Mon Jun 13 20:58:20 2022

Changes the InputChip to support selectable state

- Updates to the InputChip design tokens
- API changes to the InputChip to support a selectable state
- Changes to the FilterChip colors to support a selected disabled state
- Fixed a documentation bug which wrongfully indicated that the onClick callback is nullable

Bug: 235827062
Bug: 235792432
Test: ChipTest & ChipScreenshotTest
Relnote: "API changes to the InputChip implementation to support a
selectable state per the Material Design spec.
Additional support at the FilterChip colors for selected disabled state."

Change-Id: I552440f329616d514ea67c724b8aec6e985066e1

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/tokens/InputChipTokens.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ChipTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Chip.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/ChipSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ChipScreenshotTest.kt
M compose/material3/material3/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2124417

sg...@google.com <sg...@google.com> Jun 16, 2022 11:07PM

Marked as fixed.

Issue 235792432