[AGP-7.3.0-beta03] ShrinkResourcesNewShrinkerTask is failed when there is an empty line after xml declaration [235863809]

Fixed

Bug

Status Update

No update yet.

Description

mi...@mercurydevelopment.com

created issue #1

Jun 14, 2022 01:26PM

Our app uses Zoom SDK which contains files like this in res/raw folder:

<?xml version="1.0" encoding="utf-8"?>

<app name="zChat" version="1.1">
  <module name="zChatApp" version="2.0" ></module>
  <module name="zChatUI" version="2.0" ></module>
  <module name="zWebService" version="1.0"  caps="IdleHandler"></module>
  <module name="zData" version="1.0" ></module>
</app>

As you can see there is an empty line after xml declaration.

Both AGP 7.3.0-beta03 and AGP 7.4.0-alpha04 can't build an app containing this file with the following exception:

Caused by: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[1,1]
Message: Content is not allowed in prolog.
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLStreamReaderImpl.next(XMLStreamReaderImpl.java:652)
	at com.android.build.gradle.internal.res.shrinker.usages.ToolsAttributeUsageRecorder.processResourceToolsAttributes(ToolsAttributeUsageRecorder.kt:69)
	at com.android.build.gradle.internal.res.shrinker.usages.ToolsAttributeUsageRecorder.processRawXml(ToolsAttributeUsageRecorder.kt:49)
	at com.android.build.gradle.internal.res.shrinker.usages.ToolsAttributeUsageRecorder.access$processRawXml(ToolsAttributeUsageRecorder.kt:37)
	at com.android.build.gradle.internal.res.shrinker.usages.ToolsAttributeUsageRecorder$recordUsages$2.accept(ToolsAttributeUsageRecorder.kt:45)
	at com.android.build.gradle.internal.res.shrinker.usages.ToolsAttributeUsageRecorder$recordUsages$2.accept(ToolsAttributeUsageRecorder.kt:45)
	at com.android.build.gradle.internal.res.shrinker.usages.ToolsAttributeUsageRecorder.recordUsages(ToolsAttributeUsageRecorder.kt:45)
	at com.android.build.gradle.internal.res.shrinker.ResourceShrinkerImpl.analyze(ResourceShrinkerImpl.kt:85)
	at com.android.build.gradle.internal.transforms.ShrinkProtoResourcesAction.doExecute(ShrinkResourcesNewShrinkerTask.kt:302)

When there is no files with an empty line after xml declaration ShrinkResourcesNewShrinkerTask executes correctly.

AGP 7.3.0-beta02 doesn't have this issue.

The issue is probably related to these changes: https://cs.android.com/android-studio/platform/tools/base/+/a01dac7c7fff60e3f98c90f50f5295415f623b80

Comments

je...@google.com <je...@google.com> Jun 15, 2022 04:13PM

Reassigned to lu...@google.com.

lu...@google.com <lu...@google.com> #2Jul 1, 2022 02:05PM

The reason this has not been seen before now is that JDK-8272564 was done for JDK-18 and that it also require min API level 28. The reason the Espresso library expose this is that (most likely) internal Google build tools have JDK-8272564 applied generating invoke-interface on Object methods.

mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #3Jul 1, 2022 03:20PM

Project: r8
Branch: main

commit 6041b16a28b5966e6975340c03261c4fef61b794
Author: Søren Gjesse <sgjesse@google.com>
Date: Thu Mar 02 14:39:27 2023

Also apply the rewriting for JDK-8272564 up to Andorid R

Fixes:

Issue 235863809

Description

Issue summary

Comments

je...@google.com <je...@google.com> Jun 15, 2022 04:13PM

lu...@google.com <lu...@google.com> #2Jul 1, 2022 02:05PM

mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #3Jul 1, 2022 03:20PM

lu...@google.com <lu...@google.com> #4Jul 1, 2022 03:25PM

lu...@google.com <lu...@google.com> #5Jul 4, 2022 05:27PM

mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #6Jul 5, 2022 06:58AM

lu...@google.com <lu...@google.com> Aug 8, 2022 09:37AM

mi...@mercurydevelopment.com <mi...@mercurydevelopment.com> #7Sep 21, 2022 03:53PM

lu...@google.com <lu...@google.com> #8Sep 27, 2022 04:24PM

yu...@gmail.com <yu...@gmail.com> #9Nov 5, 2022 08:53AM

d....@pay-s.ru <d....@pay-s.ru> #10Nov 29, 2022 09:11AM

da...@gmail.com <da...@gmail.com> #11Dec 7, 2022 12:59PM

da...@gmail.com <da...@gmail.com> #12Dec 7, 2022 02:29PM

ra...@gmail.com <ra...@gmail.com> #13Jan 16, 2023 09:16AM

ro...@gmail.com <ro...@gmail.com> #14Jan 17, 2023 07:51AM

d....@pay-s.ru <d....@pay-s.ru> #15Feb 14, 2023 01:06PM

ya...@gmail.com <ya...@gmail.com> #16Mar 6, 2023 10:51PM

tr...@gmail.com <tr...@gmail.com> #17Apr 11, 2023 11:23AM

bu...@gmail.com <bu...@gmail.com> #18May 6, 2023 08:44AM

rj...@gmail.com <rj...@gmail.com> #19May 25, 2023 02:30PM

gi...@indiamart.com <gi...@indiamart.com> #20Jun 19, 2023 04:09AM

li...@gmail.com <li...@gmail.com> #21Jun 26, 2023 10:30AM

au...@gmail.com <au...@gmail.com> #22Jul 8, 2023 10:46AM

sa...@pocketfm.com <sa...@pocketfm.com> #23Aug 16, 2023 04:58AM

ar...@gmail.com <ar...@gmail.com> #24Sep 19, 2023 06:25AM

ng...@gmail.com <ng...@gmail.com> #25Nov 17, 2023 06:06AM

sg...@google.com <sg...@google.com> #26Nov 17, 2023 10:10AM

ru...@gmail.com <ru...@gmail.com> #27Apr 25, 2024 07:15AM

Add comment

Issue metadata