Imposible to align custom font [235876330]

Fixed

Feature Request

Status Update

No update yet.

Description

iv...@bandlab.com

created issue #1

Jun 14, 2022 02:40AM

We use a custom font (developed by 3rd party company) in our app, and we found that by using the recently introduced text style setting includeFontPadding=false we cannot center text properly (see the attached screenshot).

Example:

Text(
    text = "Tough Bounce",
    color = Color.Black,
    style = TextStyle(
        fontSize = 12.sp,
        lineHeight = 16.sp,
        fontFamily = null, // custom font family here
        platformStyle = PlatformTextStyle(
            paragraphStyle = PlatformParagraphStyle(includeFontPadding = false),
            spanStyle = null
        ),
        lineHeightStyle = LineHeightStyle(
            alignment = LineHeightStyle.Alignment.Center,
            trim = LineHeightStyle.Trim.None
        )
    ),
)

More information in this thread: https://kotlinlang.slack.com/archives/CJLTWPH7S/p1654746582388999?thread_ts=1617664367.220300&cid=CJLTWPH7S

Jetpack Compose version: 1.2.0-beta03
Jetpack Compose component used: BasicText/Text, TextStyle
Android Studio Build: #AI-213.7172.25.2211.8624637
Kotlin version: 1.6.21
Devices/Android versions reproduced on: any
Keyboard (i.e. Gboard, Samsung, etc): -

fonts.jpg

319 KB

View

Download

Comments

si...@google.com <si...@google.com> Jun 14, 2022 04:04PM

Reassigned to si...@google.com.

si...@google.com <si...@google.com> #2Jul 24, 2022 02:49PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

si...@google.com <si...@google.com> #3Jul 30, 2022 03:16AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

Message last modified on Jul 30, 2022 03:17AM

si...@google.com <si...@google.com> #4Aug 1, 2022 06:03PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

si...@google.com <si...@google.com> #5Aug 1, 2022 06:04PM

Here is a screenshot with line heightstyle trim.none, align.center (after the font update)

Message last modified on Aug 2, 2022 01:06AM

Mon Aug 01 2022 11:04:05 GMT-0700 (Pacific Daylight Time).png

355 KB

View

Download

si...@google.com <si...@google.com> #6Aug 1, 2022 06:05PM

I will consider making the constructor public however since the whole system is based on those numbers in the font, I think it is better to update the font if it was possible. (i.e. using fontTools link)

si...@google.com <si...@google.com> Aug 3, 2022 12:49AM

Marked as fixed.

ap...@google.com <ap...@google.com> #7Aug 3, 2022 12:49AM

Project: platform/frameworks/support
Branch: androidx-main

commit eea55e5a6d2f6e243dc0728403d293c79e5a9bda
Author: siyamed <siyamed@google.com>
Date: Mon Aug 01 10:53:31 2022

Make LineHeightStyle.Alignment constructor public

Some font ascent/descent/ymin/ymax values are not "correct".
for example ascent goes over ymax; or descent goes below ymin.

This CL makes the alignment constructor public so that fine tuning
for cases such as center is possible.

RelNote: "LineHeightStyle.Alignment constructor is now
public (experimental)"

Test: Existing tests already cover
Bug: 235876330
Change-Id: I4bbbe53b2088b9b211b86919c55bf6be88572baf

M compose/ui/ui-text/api/restricted_current.txt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/style/LineHeightStyle.kt
M text/text/src/main/java/androidx/compose/ui/text/android/style/LineHeightStyleSpan.kt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M text/text/src/androidTest/java/androidx/compose/ui/text/android/TextLayoutTest.kt
M text/text/src/androidTest/java/androidx/compose/ui/text/android/style/LineHeightStyleSpanTest.kt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/src/androidMain/kotlin/androidx/compose/ui/text/platform/extensions/SpannableExtensions.android.kt

https://android-review.googlesource.com/2169775

ai...@gmail.com <ai...@gmail.com> #8Aug 4, 2022 05:30AM

Thanks a lot for those changes. We will try to fix font with fontTools, but I think having Alignment constructor public still can be useful for fine tuning of the font