StackSampling Profiling Issue - SimplePerf Fails to Start [236109374]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 15, 2022 11:19AM

Component used: androidx.benchmark

Version used: built from HEAD (master) on 6th June 2022

Devices/Android versions reproduced on: Google Pixel 5 (redfin-userdebug) running UpsideDownCake built from HEAD (master) on 6th June 2022

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue: uploaded at http://ag/18910949 (after cloning, run with atest cts/common/device-side/bedstead/nene/src/test/java/com/android/bedstead/nene/benchmarking/NeneBenchmarksTest.java)

arm64-v8a NeneTest
------------------
com.android.bedstead.nene.test (1 Test)
[1/1] com.android.bedstead.nene.benchmarking.NeneBenchmarksTest#benchmarkAddingNumbers: FAILED (1.697s)

STACKTRACE:
java.lang.Error: failed to receive simpleperf start flag
	at androidx.benchmark.simpleperf.ProfileSession.startSimpleperfRecording(ProfileSession.java:368)
	at androidx.benchmark.simpleperf.ProfileSession.startRecording(ProfileSession.java:142)
	at androidx.benchmark.simpleperf.ProfileSession.startRecording(ProfileSession.java:127)
	at androidx.benchmark.StackSamplingSimpleperf.start(Profiler.kt:233)
	at androidx.benchmark.BenchmarkState.beginRunningStage(BenchmarkState.kt:236)
	at androidx.benchmark.BenchmarkState.startNextRepeat(BenchmarkState.kt:306)
	at androidx.benchmark.BenchmarkState.keepRunningInternal(BenchmarkState.kt:403)
	at androidx.benchmark.BenchmarkState.keepRunning(BenchmarkState.kt:360)
	at com.android.bedstead.nene.benchmarking.NeneBenchmarksTest.benchmarkAddingNumbers(NeneBenchmarksTest.java:44)


Summary (Test executed with 1 devices.)
-------
arm64-v8a NeneTest: Passed: 0, Failed: 1, Ignored: 0, Assumption Failed: 0

Comments

al...@google.com <al...@google.com> #2Jun 15, 2022 11:22AM

Since this is happening in Tink, rather than in the AndroidX library, it would be best to open an issue with that project, as there isn't an easy way for us to fix this.

ra...@google.com <ra...@google.com> #3Jun 15, 2022 03:52PM

@2 I don't know what "Tink" is, but here, created:

https://github.com/google/tink/issues/534

Would this mean that this bug report should be written there as well:

https://issuetracker.google.com/issues/176215143
?

al...@google.com <al...@google.com> #4Jun 17, 2022 12:41PM

Tink is the library that does the heavy lifting in Jetpack Security.

And yes, potentially raising that issue with the Tink team directly could help.

cc...@google.com <cc...@google.com> Sep 29, 2022 11:14PM

Reassigned to cc...@google.com.

ap...@google.com <ap...@google.com> #5Sep 30, 2022 01:55AM

Marked as fixed.

@4 Well why didn't Google offer it there? Crashes are far more important than warning logs...
Here, created it there too:

https://github.com/google/tink/issues/535

na...@google.com <na...@google.com> #6Oct 24, 2022 01:36PM

Anyone here solved the issue? I have implemented the jetpack security and got the same crashes.

Issue 236109374