StackSampling Profiling Issue - SimplePerf Fails to Start [236109374]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 15, 2022 11:19AM

Component used: androidx.benchmark

Version used: built from HEAD (master) on 6th June 2022

Devices/Android versions reproduced on: Google Pixel 5 (redfin-userdebug) running UpsideDownCake built from HEAD (master) on 6th June 2022

If this is a bug in the library, we would appreciate if you could attach:

Sample project to trigger the issue: uploaded at http://ag/18910949 (after cloning, run with atest cts/common/device-side/bedstead/nene/src/test/java/com/android/bedstead/nene/benchmarking/NeneBenchmarksTest.java)

arm64-v8a NeneTest
------------------
com.android.bedstead.nene.test (1 Test)
[1/1] com.android.bedstead.nene.benchmarking.NeneBenchmarksTest#benchmarkAddingNumbers: FAILED (1.697s)

STACKTRACE:
java.lang.Error: failed to receive simpleperf start flag
	at androidx.benchmark.simpleperf.ProfileSession.startSimpleperfRecording(ProfileSession.java:368)
	at androidx.benchmark.simpleperf.ProfileSession.startRecording(ProfileSession.java:142)
	at androidx.benchmark.simpleperf.ProfileSession.startRecording(ProfileSession.java:127)
	at androidx.benchmark.StackSamplingSimpleperf.start(Profiler.kt:233)
	at androidx.benchmark.BenchmarkState.beginRunningStage(BenchmarkState.kt:236)
	at androidx.benchmark.BenchmarkState.startNextRepeat(BenchmarkState.kt:306)
	at androidx.benchmark.BenchmarkState.keepRunningInternal(BenchmarkState.kt:403)
	at androidx.benchmark.BenchmarkState.keepRunning(BenchmarkState.kt:360)
	at com.android.bedstead.nene.benchmarking.NeneBenchmarksTest.benchmarkAddingNumbers(NeneBenchmarksTest.java:44)


Summary (Test executed with 1 devices.)
-------
arm64-v8a NeneTest: Passed: 0, Failed: 1, Ignored: 0, Assumption Failed: 0

Comments

al...@google.com <al...@google.com> #2Jun 15, 2022 11:22AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ra...@google.com <ra...@google.com> #3Jun 15, 2022 03:52PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

al...@google.com <al...@google.com> #4Jun 17, 2022 12:41PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

cc...@google.com <cc...@google.com> Sep 29, 2022 11:14PM

Reassigned to cc...@google.com.

ap...@google.com <ap...@google.com> #5Sep 30, 2022 01:55AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a6e57c90b1ea38232e3149e6f47b68c5fffc6769
Author: Chris Craik <ccraik@google.com>
Date: Mon Sep 26 16:50:11 2022

Switch to cpu-clock event in simpleperf sampled profiling

Fixes: 236109374
Test: ./gradlew benchmark:b-c:cC -P android.testInstrumentationRunnerArguments.class=androidx.benchmark.ProfilerTest

Relnote: "Fixes SampledProfiling crash on API 33+."

Also updated/rebased androidx.benchmark.simpleperf files from api_profiling.

Change-Id: I40743831d240327bbf3d89d09f510d9db09e67c0

M benchmark/benchmark-common/src/main/java/androidx/benchmark/simpleperf/ProfileSession.java
M benchmark/benchmark-common/src/main/java/androidx/benchmark/simpleperf/RecordOptions.java
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Profiler.kt

https://android-review.googlesource.com/2237301

na...@google.com <na...@google.com> #6Oct 24, 2022 01:36PM

The following release(s) address this bug:

androidx.benchmark:benchmark-common:1.2.0-alpha06

Issue 236109374