Add extended function to parse string reference as String values [236269380]

Fixed

Feature Request

Status Update

No update yet.

Description

cl...@google.com

created issue #1

Jun 16, 2022 05:05PM

AbstractAppBarOnDestinationChangedListener#onDestinationChanged has been updated to parse string ReferenceType arguments into String values instead of the default Int reference value.

Would be nice if we add this as a NavDestination extended function for custom implementations of onDestinationChanged.

Comments

ap...@google.com <ap...@google.com> #2Jul 20, 2022 10:11PM

Marked as fixed.

Hey Doris, any ideas on where this random animation could be coming from?

il...@google.com <il...@google.com> #3Jul 20, 2022 11:10PM

Re comment #1,

I tried the repro project locally. I was not able to reproduce in the the tip of tree compose code base, after dozens of attempts. It's possible the issue has been fixed recently.

Could you try the latest androidx snapshot here: https://androidx.dev/snapshots/builds and let us know if you still see the issue?

na...@google.com <na...@google.com> #4Sep 12, 2022 05:52PM

Hi! Thank you for checking into it and giving it a try.

Unfortunately, the issue is still reproducible with snapshot 12123985, 2.8.0-SNAPSHOT for navigation, and 1.8.0-SNAPSHOT for compose.

I've pushed an update containing SNAPSHOT dependencies and automated reproduction attempts: https://github.com/smelfungus/NavHostAnimationIssue

Now, it's sufficient to launch the application and wait.

Here's a new video: https://drive.google.com/file/d/1q3C3ErIzPbTdfLsZH85KgPGNqmL-h1MN/view?usp=sharing

Issue 236269380

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jul 20, 2022 10:11PM

il...@google.com <il...@google.com> #3Jul 20, 2022 11:10PM

na...@google.com <na...@google.com> #4Sep 12, 2022 05:52PM

Add comment

Issue metadata