[arch/core/core-testing] Fix 4 suppressed lint issue(s) in `JunitTaskExecutorRule.java` [236472103]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 18, 2022 06:22PM

The following 4 lint issue(s) are suppressed in src/main/java/androidx/arch/core/executor/JunitTaskExecutorRule.java. Please remove these suppressions in arch/core/core-testing/lint-baseline.xml and address the associated issues.

Line number: 58
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public TaskExecutor getTaskExecutor() {
           ~~~~~~~~~~~~

Line number: 72
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public Statement apply(final Statement base, Description description) {
           ~~~~~~~~~

Line number: 72
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public Statement apply(final Statement base, Description description) {
                                 ~~~~~~~~~

Line number: 72
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public Statement apply(final Statement base, Description description) {
                                                 ~~~~~~~~~~~

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 08:34PM

Accepted by al...@google.com.

Is there any way to use this while it's not available, without a big if else where we do everything duplicated? Like this example.

        val notification = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
            Notification.Builder(...)
                .setContentTitle("Title")
                .setStyle(...)
                // Duplicate everything here!!!
                .build()
        } else {
            NotificationCompat.Builder(...)
                .setContentTitle("Title")
                .setStyle(...)
                // Duplicate everything here!!!
                .build()
        }

ap...@google.com <ap...@google.com> #3Jun 22, 2022 04:56PM

Marked as fixed.

Hi,

Could you at least tell us if you will add the CallStyle to the NotificationCompat API?

Best regards,

na...@google.com <na...@google.com> #4Jan 11, 2023 08:12PM

Yes. Our goal is to provide an implementation that uses CallStyle on API 31+ and uses the new fields to produce a usable call notification, based on the device's standard template, on older versions of Android.

cl...@gmail.com <cl...@gmail.com> #5Feb 7, 2023 08:48AM

Thanks for the answer. Do you have an estimated ETA?

sa...@gmail.com <sa...@gmail.com> #6Dec 1, 2024 12:36AM

Any update on this please?

Issue 236472103