[coordinatorlayout/coordinatorlayout] Fix 17 suppressed lint issue(s) in `CoordinatorLayout.java` [236474453]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 18, 2022 07:06PM

The following 17 lint issue(s) are suppressed in src/main/java/androidx/coordinatorlayout/widget/CoordinatorLayout.java. Please remove these suppressions in coordinatorlayout/coordinatorlayout/lint-baseline.xml and address the associated issues.

Line number: 345
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    protected boolean verifyDrawable(Drawable who) {
                                     ~~~~~~~~

Line number: 397
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public final WindowInsetsCompat getLastWindowInsets() {
                 ~~~~~~~~~~~~~~~~~~

Line number: 793
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onMeasureChild(View child, int parentWidthMeasureSpec, int widthUsed,
                               ~~~~

Line number: 1792
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean onStartNestedScroll(View child, View target, int axes, int type) {
                                       ~~~~

Line number: 1792
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean onStartNestedScroll(View child, View target, int axes, int type) {
                                                   ~~~~

Line number: 1823
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedScrollAccepted(View child, View target, int axes, int type) {
                                       ~~~~

Line number: 1823
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedScrollAccepted(View child, View target, int axes, int type) {
                                                   ~~~~

Line number: 1850
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onStopNestedScroll(View target, int type) {
                                   ~~~~

Line number: 1879
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedScroll(View target, int dxConsumed, int dyConsumed,
                               ~~~~

Line number: 1940
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedPreScroll(View target, int dx, int dy, int[] consumed, int  type) {
                                  ~~~~

Line number: 1940
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedPreScroll(View target, int dx, int dy, int[] consumed, int  type) {
                                                               ~~~~~

Line number: 2124
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public Behavior(Context context, AttributeSet attrs) {
                        ~~~~~~~

Line number: 2124
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public Behavior(Context context, AttributeSet attrs) {
                                         ~~~~~~~~~~~~

Line number: 2929
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public LayoutParams(LayoutParams p) {
                            ~~~~~~~~~~~~

Line number: 2933
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public LayoutParams(MarginLayoutParams p) {
                            ~~~~~~~~~~~~~~~~~~

Line number: 2937
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public LayoutParams(ViewGroup.LayoutParams p) {
                            ~~~~~~~~~~~~~~~~~~~~~~

Line number: 3290
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    protected Parcelable onSaveInstanceState() {
              ~~~~~~~~~~

Comments

il...@google.com <il...@google.com> Jun 22, 2022 07:34PM

Assigned to cl...@google.com.

ap...@google.com <ap...@google.com> #2Jun 23, 2022 10:33PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit b73965a83ae16a1c67d29a1c431aa55f04241157
Author: Clara Fok <clarafok@google.com>
Date: Wed Jun 22 15:52:55 2022

Lint fix UnknownNullness in CoordinatorLayout

Test: ./gradlew coordinatorlayout:coordinatorlayout:cC
Fixes: 236474453

Relnote: "Added Nullability annotations in CoordinatorLayout.java"
Change-Id: Ieb64783622f7931cc7b43bed3a4088c5595e02c1

M coordinatorlayout/coordinatorlayout/api/current.txt
M coordinatorlayout/coordinatorlayout/api/restricted_current.txt
M coordinatorlayout/coordinatorlayout/src/main/java/androidx/coordinatorlayout/widget/CoordinatorLayout.java
M coordinatorlayout/coordinatorlayout/api/public_plus_experimental_current.txt
M coordinatorlayout/coordinatorlayout/api/api_lint.ignore

https://android-review.googlesource.com/2134821

na...@google.com <na...@google.com> #3Sep 20, 2023 07:16PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.coordinatorlayout:coordinatorlayout:1.3.0-alpha01

Issue 236474453

Description

Issue summary

Comments

il...@google.com <il...@google.com> Jun 22, 2022 07:34PM

ap...@google.com <ap...@google.com> #2Jun 23, 2022 10:33PM

na...@google.com <na...@google.com> #3Sep 20, 2023 07:16PM

Add comment

Issue metadata