[recyclerview/recyclerview] Fix 57 suppressed lint issue(s) in `StaggeredGridLayoutManager.java` [236487209]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 18, 2022 11:42PM

The following 57 lint issue(s) are suppressed in src/main/java/androidx/recyclerview/widget/StaggeredGridLayoutManager.java. Please remove these suppressions in recyclerview/recyclerview/lint-baseline.xml and address the associated issues.

Line number: 227
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public StaggeredGridLayoutManager(Context context, AttributeSet attrs, int defStyleAttr,
                                      ~~~~~~~

Line number: 227
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public StaggeredGridLayoutManager(Context context, AttributeSet attrs, int defStyleAttr,
                                                       ~~~~~~~~~~~~

Line number: 321
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onDetachedFromWindow(RecyclerView view, RecyclerView.Recycler recycler) {
                                     ~~~~~~~~~~~~

Line number: 321
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onDetachedFromWindow(RecyclerView view, RecyclerView.Recycler recycler) {
                                                        ~~~~~~~~~~~~~~~~~~~~~

Line number: 526
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void assertNotInLayoutOrScroll(String message) {
                                          ~~~~~~

Line number: 583
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void setMeasuredDimension(Rect childrenBounds, int wSpec, int hSpec) {
                                     ~~~~

Line number: 603
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onLayoutChildren(RecyclerView.Recycler recycler, RecyclerView.State state) {
                                 ~~~~~~~~~~~~~~~~~~~~~

Line number: 603
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onLayoutChildren(RecyclerView.Recycler recycler, RecyclerView.State state) {
                                                                 ~~~~~~~~~~~~~~~~~~

Line number: 733
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onLayoutCompleted(RecyclerView.State state) {
                                  ~~~~~~~~~~~~~~~~~~

Line number: 965
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int[] findFirstVisibleItemPositions(int[] into) {
           ~~~~~

Line number: 965
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int[] findFirstVisibleItemPositions(int[] into) {
                                               ~~~~~

Line number: 997
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int[] findFirstCompletelyVisibleItemPositions(int[] into) {
           ~~~~~

Line number: 997
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int[] findFirstCompletelyVisibleItemPositions(int[] into) {
                                                         ~~~~~

Line number: 1029
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int[] findLastVisibleItemPositions(int[] into) {
           ~~~~~

Line number: 1029
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int[] findLastVisibleItemPositions(int[] into) {
                                              ~~~~~

Line number: 1061
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int[] findLastCompletelyVisibleItemPositions(int[] into) {
           ~~~~~

Line number: 1061
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int[] findLastCompletelyVisibleItemPositions(int[] into) {
                                                        ~~~~~

Line number: 1075
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int computeHorizontalScrollOffset(RecyclerView.State state) {
                                             ~~~~~~~~~~~~~~~~~~

Line number: 1090
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int computeVerticalScrollOffset(RecyclerView.State state) {
                                           ~~~~~~~~~~~~~~~~~~

Line number: 1095
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int computeHorizontalScrollExtent(RecyclerView.State state) {
                                             ~~~~~~~~~~~~~~~~~~

Line number: 1110
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int computeVerticalScrollExtent(RecyclerView.State state) {
                                           ~~~~~~~~~~~~~~~~~~

Line number: 1115
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int computeHorizontalScrollRange(RecyclerView.State state) {
                                            ~~~~~~~~~~~~~~~~~~

Line number: 1130
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int computeVerticalScrollRange(RecyclerView.State state) {
                                          ~~~~~~~~~~~~~~~~~~

Line number: 1229
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onRestoreInstanceState(Parcelable state) {
                                       ~~~~~~~~~~

Line number: 1243
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public Parcelable onSaveInstanceState() {
           ~~~~~~~~~~

Line number: 1293
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onInitializeAccessibilityEvent(AccessibilityEvent event) {
                                               ~~~~~~~~~~~~~~~~~~

Line number: 1475
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onItemsRemoved(RecyclerView recyclerView, int positionStart, int itemCount) {
                               ~~~~~~~~~~~~

Line number: 1480
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onItemsAdded(RecyclerView recyclerView, int positionStart, int itemCount) {
                             ~~~~~~~~~~~~

Line number: 1485
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onItemsChanged(RecyclerView recyclerView) {
                               ~~~~~~~~~~~~

Line number: 1491
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onItemsMoved(RecyclerView recyclerView, int from, int to, int itemCount) {
                             ~~~~~~~~~~~~

Line number: 1496
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onItemsUpdated(RecyclerView recyclerView, int positionStart, int itemCount,
                               ~~~~~~~~~~~~

Line number: 1497
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


            Object payload) {
            ~~~~~~

Line number: 2005
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int scrollHorizontallyBy(int dx, RecyclerView.Recycler recycler,
                                            ~~~~~~~~~~~~~~~~~~~~~

Line number: 2006
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


            RecyclerView.State state) {
            ~~~~~~~~~~~~~~~~~~

Line number: 2011
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public int scrollVerticallyBy(int dy, RecyclerView.Recycler recycler,
                                          ~~~~~~~~~~~~~~~~~~~~~

Line number: 2012
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


            RecyclerView.State state) {
            ~~~~~~~~~~~~~~~~~~

Line number: 2025
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public PointF computeScrollVectorForPosition(int targetPosition) {
           ~~~~~~

Line number: 2042
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void smoothScrollToPosition(RecyclerView recyclerView, RecyclerView.State state,
                                       ~~~~~~~~~~~~

Line number: 2042
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void smoothScrollToPosition(RecyclerView recyclerView, RecyclerView.State state,
                                                                  ~~~~~~~~~~~~~~~~~~

Line number: 2084
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void collectAdjacentPrefetchPositions(int dx, int dy, RecyclerView.State state,
                                                                 ~~~~~~~~~~~~~~~~~~

Line number: 2085
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


            LayoutPrefetchRegistry layoutPrefetchRegistry) {
            ~~~~~~~~~~~~~~~~~~~~~~

Line number: 2221
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public RecyclerView.LayoutParams generateDefaultLayoutParams() {
           ~~~~~~~~~~~~~~~~~~~~~~~~~

Line number: 2232
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public RecyclerView.LayoutParams generateLayoutParams(Context c, AttributeSet attrs) {
           ~~~~~~~~~~~~~~~~~~~~~~~~~

Line number: 2232
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public RecyclerView.LayoutParams generateLayoutParams(Context c, AttributeSet attrs) {
                                                          ~~~~~~~

Line number: 2232
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public RecyclerView.LayoutParams generateLayoutParams(Context c, AttributeSet attrs) {
                                                                     ~~~~~~~~~~~~

Line number: 2237
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public RecyclerView.LayoutParams generateLayoutParams(ViewGroup.LayoutParams lp) {
           ~~~~~~~~~~~~~~~~~~~~~~~~~

Line number: 2237
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public RecyclerView.LayoutParams generateLayoutParams(ViewGroup.LayoutParams lp) {
                                                          ~~~~~~~~~~~~~~~~~~~~~~

Line number: 2246
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean checkLayoutParams(RecyclerView.LayoutParams lp) {
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~

Line number: 2256
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public View onFocusSearchFailed(View focused, int direction, RecyclerView.Recycler recycler,
                                    ~~~~

Line number: 2256
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public View onFocusSearchFailed(View focused, int direction, RecyclerView.Recycler recycler,
                                                                 ~~~~~~~~~~~~~~~~~~~~~

Line number: 2257
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


            RecyclerView.State state) {
            ~~~~~~~~~~~~~~~~~~

Line number: 2423
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public LayoutParams(Context c, AttributeSet attrs) {
                            ~~~~~~~

Line number: 2423
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public LayoutParams(Context c, AttributeSet attrs) {
                                       ~~~~~~~~~~~~

Line number: 2431
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public LayoutParams(ViewGroup.MarginLayoutParams source) {
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Line number: 2435
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public LayoutParams(ViewGroup.LayoutParams source) {
                            ~~~~~~~~~~~~~~~~~~~~~~

Line number: 2439
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public LayoutParams(RecyclerView.LayoutParams source) {
                            ~~~~~~~~~~~~~~~~~~~~~~~~~

Line number: 3164
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public SavedState(SavedState other) {
                          ~~~~~~~~~~

Comments

sj...@google.com <sj...@google.com> Jun 21, 2022 04:46PM

Assigned to sj...@google.com.

ap...@google.com <ap...@google.com> #2Jun 22, 2022 05:44PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6492a281bd17da7537f453a3fc01d182c79a169e
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Mon Jul 27 17:24:43 2020

Rename BottomNavigationItem parameters

text -> label to match the Material.io documentation and the `alwaysShowLabels` parameter
onSelected -> onSelect to match the tense we use in other components
activeColor -> selectedContentColor to be more clear about what this 'color' is, and match the selected state
inactiveColor -> unselectedContentColor to be more clear about waht this 'color' is, and match the not-selected state

Additionally fixes the ordering of parameters so that all required parameters are first, followed by the Modifier param.

Bug:

b/161809324

Test: ./gradlew updateApi
Relnote: "Renames BottomNavigationItem's `text` parameter to `label`, `onSelected` to `onSelect`, `activeColor` to `selectedContentColor`, `inactiveColor` to `unselectedContentColor` and updates parameter ordering to match guidelines."
Change-Id: Icb605dac9b76a0204a2a9d675530da8897f817d5

M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/samples/src/main/java/androidx/compose/material/samples/BottomNavigationSamples.kt
M ui/ui-material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationTest.kt
M ui/ui-material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt

https://android-review.googlesource.com/1373097

sj...@google.com <sj...@google.com> Jun 22, 2022 06:02PM

Marked as fixed.

Issue 236487209

Description

Issue summary

Comments

sj...@google.com <sj...@google.com> Jun 21, 2022 04:46PM

ap...@google.com <ap...@google.com> #2Jun 22, 2022 05:44PM

sj...@google.com <sj...@google.com> Jun 22, 2022 06:02PM

Add comment

Issue metadata