[recyclerview/recyclerview] Fix 8 suppressed lint issue(s) in `ItemTouchUIUtil.java` [236487210]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 18, 2022 11:42PM

The following 8 lint issue(s) are suppressed in src/main/java/androidx/recyclerview/widget/ItemTouchUIUtil.java. Please remove these suppressions in recyclerview/recyclerview/lint-baseline.xml and address the associated issues.

Line number: 41
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    void onDraw(Canvas c, RecyclerView recyclerView, View view,
                ~~~~~~

Line number: 41
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    void onDraw(Canvas c, RecyclerView recyclerView, View view,
                          ~~~~~~~~~~~~

Line number: 41
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    void onDraw(Canvas c, RecyclerView recyclerView, View view,
                                                     ~~~~

Line number: 48
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    void onDrawOver(Canvas c, RecyclerView recyclerView, View view,
                    ~~~~~~

Line number: 48
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    void onDrawOver(Canvas c, RecyclerView recyclerView, View view,
                              ~~~~~~~~~~~~

Line number: 48
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    void onDrawOver(Canvas c, RecyclerView recyclerView, View view,
                                                         ~~~~

Line number: 55
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    void clearView(View view);
                   ~~~~

Line number: 61
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    void onSelected(View view);
                    ~~~~

Comments

sj...@google.com <sj...@google.com> Jun 21, 2022 03:33PM

Assigned to sj...@google.com.

sj...@google.com <sj...@google.com> Jun 22, 2022 02:24PM

Marked as fixed.

ap...@google.com <ap...@google.com> #2Jun 22, 2022 02:24PM

I believe that this is following on from issue 123186596, and as mentioned there, is a regression from version 1.0.0.

In the linked thread it is suggested that withOnItemActivatedListener can be used to correctly handle click events on the view. I've had a look through the sample project here and it seems like this will work for most cases. It also makes sense why this is required.

For my use-case I would like a reference to the view in the ViewHolder for shared element transitions - setting on onClickListener in the ViewHolder made this easy. I'll have to work around by finding the view holder with the motion event for now.

I think it should be clearer in the version release notes that this behaviour change is present.

Issue 236487210

Description

Issue summary

Comments

sj...@google.com <sj...@google.com> Jun 21, 2022 03:33PM

sj...@google.com <sj...@google.com> Jun 22, 2022 02:24PM

ap...@google.com <ap...@google.com> #2Jun 22, 2022 02:24PM

Add comment

Issue metadata