[security/security-crypto] Fix 2 suppressed lint issue(s) in `EncryptedFile.java` [236488480]

Internal Cleanup

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 19, 2022 12:29AM

The following 2 lint issue(s) are suppressed in src/main/java/androidx/security/crypto/EncryptedFile.java. Please remove these suppressions in security/security-crypto/lint-baseline.xml and address the associated issues.

Line number: 352
Lint check ID: BanSynchronizedMethods
Lint message: Use of synchronized methods is not recommended


        @Override
        ^

Line number: 357
Lint check ID: BanSynchronizedMethods
Lint message: Use of synchronized methods is not recommended


        @Override
        ^

Comments

da...@google.com <da...@google.com> Oct 13, 2022 10:55PM

Assigned to da...@google.com.

da...@google.com <da...@google.com> Oct 14, 2022 09:34PM

Accepted by da...@google.com.

ap...@google.com <ap...@google.com> #2Oct 20, 2022 09:23PM

I am not sure I understand the use case. how can the benchmark be code to real world scenario when it's not possible to do right now ? which scenario is it ?

In any case, since this would be for benchmarking, this would clearly not be available through the public DSL. We should find a semi-private way of doing this (maybe the private variant API object could offer that functionality for instance or a property).

is...@google.com <is...@google.com> Aug 10, 2023 07:34AM

Status: New

Issue 236488480

Description

Issue summary

Comments

da...@google.com <da...@google.com> Oct 13, 2022 10:55PM

da...@google.com <da...@google.com> Oct 14, 2022 09:34PM

ap...@google.com <ap...@google.com> #2Oct 20, 2022 09:23PM

is...@google.com <is...@google.com> Aug 10, 2023 07:34AM

Add comment

Issue metadata