[swiperefreshlayout/swiperefreshlayout] Fix 17 suppressed lint issue(s) in `SwipeRefreshLayout.java` [236497776]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 19, 2022 05:32AM

The following 17 lint issue(s) are suppressed in src/main/java/androidx/swiperefreshlayout/widget/SwipeRefreshLayout.java. Please remove these suppressions in swiperefreshlayout/swiperefreshlayout/lint-baseline.xml and address the associated issues.

Line number: 290
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    protected Parcelable onSaveInstanceState() {
              ~~~~~~~~~~

Line number: 634
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void setColorSchemeResources(@ColorRes int... colorResIds) {
                                                  ~~~~~~

Line number: 650
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void setColorSchemeColors(@ColorInt int... colors) {
                                               ~~~~~~

Line number: 918
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean onStartNestedScroll(View child, View target, int axes, int type) {
                                       ~~~~

Line number: 918
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean onStartNestedScroll(View child, View target, int axes, int type) {
                                                   ~~~~

Line number: 927
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedScrollAccepted(View child, View target, int axes, int type) {
                                       ~~~~

Line number: 927
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedScrollAccepted(View child, View target, int axes, int type) {
                                                   ~~~~

Line number: 936
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onStopNestedScroll(View target, int type) {
                                   ~~~~

Line number: 945
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedScroll(View target, int dxConsumed, int dyConsumed, int dxUnconsumed,
                               ~~~~

Line number: 952
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedPreScroll(View target, int dx, int dy, int[] consumed, int type) {
                                  ~~~~

Line number: 952
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public void onNestedPreScroll(View target, int dx, int dy, int[] consumed, int type) {
                                                               ~~~~~

Line number: 1086
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


            int dyUnconsumed, int[] offsetInWindow, int type) {
                              ~~~~~

Line number: 1092
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean dispatchNestedPreScroll(int dx, int dy, int[] consumed, int[] offsetInWindow,
                                                           ~~~~~

Line number: 1092
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean dispatchNestedPreScroll(int dx, int dy, int[] consumed, int[] offsetInWindow,
                                                                           ~~~~~

Line number: 1127
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


            int dyUnconsumed, int[] offsetInWindow) {
                              ~~~~~

Line number: 1133
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean dispatchNestedPreScroll(int dx, int dy, int[] consumed, int[] offsetInWindow) {
                                                           ~~~~~

Line number: 1133
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public boolean dispatchNestedPreScroll(int dx, int dy, int[] consumed, int[] offsetInWindow) {
                                                                           ~~~~~

Comments

ju...@google.com <ju...@google.com> Jun 21, 2022 03:03PM

Assigned to ju...@google.com.

ap...@google.com <ap...@google.com> #2Jun 23, 2022 12:46AM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ju...@google.com <ju...@google.com> Jun 23, 2022 01:09AM

Marked as fixed.

pr...@google.com <pr...@google.com> #3Feb 12, 2025 06:40PM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

Issue 236497776

Description

Issue summary

Comments

ju...@google.com <ju...@google.com> Jun 21, 2022 03:03PM

ap...@google.com <ap...@google.com> #2Jun 23, 2022 12:46AM

ju...@google.com <ju...@google.com> Jun 23, 2022 01:09AM

pr...@google.com <pr...@google.com> #3Feb 12, 2025 06:40PM

Add comment

Issue metadata