[vectordrawable/vectordrawable-animated] Fix 2 suppressed lint issue(s) in `Animatable2Compat.java` [236497942]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 19, 2022 05:35AM

The following 2 lint issue(s) are suppressed in src/main/java/androidx/vectordrawable/graphics/drawable/Animatable2Compat.java. Please remove these suppressions in vectordrawable/vectordrawable-animated/lint-baseline.xml and address the associated issues.

Line number: 63
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public void onAnimationStart(Drawable drawable) {};
                                     ~~~~~~~~

Line number: 69
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


        public void onAnimationEnd(Drawable drawable) {};
                                   ~~~~~~~~

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

Accepted by al...@google.com.

Seems that this issue will never be fixed as google has marked the multiple duplicates as `wont fix`.

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

Marked as fixed.

https://android-review.googlesource.com/c/platform/frameworks/support/+/1295992 is under review.

Adding the following block in Support4Demos.onCreate:

ViewCompat.addOnUnhandledKeyEventListener(getListView(),
new ViewCompat.OnUnhandledKeyEventListenerCompat() {
@Override
public boolean onUnhandledKeyEvent(View v, KeyEvent event) {
return false;
}
});

produces:

04-28 17:40:41.523 4608-4608/com.example.android.supportv4 I/art: Rejecting re-init on previously-failed class java.lang.Class<androidx.core.view.ViewCompat$2>
04-28 17:40:41.524 4608-4608/com.example.android.supportv4 I/art: Rejecting re-init on previously-failed class java.lang.Class<androidx.core.view.ViewCompat$2>

on a Nexus 6 API 23 emulator before the CL, and no such message with the CL

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6ef009775ee7b4b179cafa28467d3fea6bfbef49
Author: Kirill Grouchnikov <kirillg@google.com>
Date: Tue Apr 28 12:04:52 2020

Extract v28+ calls into a separate static class

So that the new View.OnUnhandledKeyEventListener class
doesn't get loaded on older platform versions.

Bug: 153695093
Test: ./gradlew appcompat:appcompat:connectedCheck --info --daemon -Pandroid.testInstrumentationRunnerArguments.class=androidx.appcompat.app.KeyEventsTestCaseWithWindowDecor
Change-Id: Id34194f77b9c7a2f0864e38d17ef6039733dee95

M core/core/src/main/java/androidx/core/view/ViewCompat.java

https://android-review.googlesource.com/1295992

Issue 236497942

Description

Issue summary

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Add comment

Issue metadata