[vectordrawable/vectordrawable-animated] Fix 2 suppressed lint issue(s) in `AnimationUtilsCompat.java` [236497996]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 19, 2022 05:35AM

The following 2 lint issue(s) are suppressed in src/main/java/androidx/vectordrawable/graphics/drawable/AnimationUtilsCompat.java. Please remove these suppressions in vectordrawable/vectordrawable-animated/lint-baseline.xml and address the associated issues.

Line number: 62
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Interpolator loadInterpolator(Context context, int id)
                  ~~~~~~~~~~~~

Line number: 62
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Interpolator loadInterpolator(Context context, int id)
                                                ~~~~~~~

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

Accepted by al...@google.com.

aosp/2133639 to fix.

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

Marked as fixed.

Closing out prior to merge for Hackathon accounting purposes.

Don't worry, it'll still get merged!

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 07343ff52ec2a5b3fdd89e7a241c11e6b19a15fb
Author: Alan Viverette <alanv@google.com>
Date: Tue Jun 21 14:43:47 2022

Fix lint issues in vectordrawable-animated

Also fixes incorrect nullability annotation in core DrawableCompat.

Relnote: Updated nullability annotations
Fixes: 236498052
Fixes: 236498029
Fixes: 236497996
Fixes: 236497942
Fixes: 236497884
Test: vectordrawable-animation suite of tests
Fixes: 236497726
Change-Id: I34cce3c167135c9020a015b08f70fb1cdba5f8ce

M vectordrawable/vectordrawable-animated/api/current.txt
M vectordrawable/vectordrawable-animated/api/restricted_1.2.0-beta01.txt
M vectordrawable/vectordrawable-animated/api/public_plus_experimental_1.2.0-beta01.txt
M vectordrawable/vectordrawable-animated/build.gradle
M core/core/api/public_plus_experimental_current.txt
M vectordrawable/vectordrawable/src/main/java/androidx/vectordrawable/graphics/drawable/AndroidResources.java
M vectordrawable/vectordrawable-animated/src/androidTest/java/androidx/vectordrawable/graphics/drawable/tests/AnimatedVectorDrawableParameterizedTest.java
M core/core/api/current.txt
M core/core/src/main/java/androidx/core/graphics/drawable/DrawableCompat.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/Animatable2Compat.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/ArgbEvaluator.java
M vectordrawable/vectordrawable-animated/api/1.2.0-beta01.txt
M core/core/api/restricted_current.txt
M vectordrawable/vectordrawable-animated/api/restricted_current.txt
M vectordrawable/vectordrawable-animated/src/androidTest/java/androidx/vectordrawable/graphics/drawable/tests/PathInterpolatorParameterizedTest.java
M vectordrawable/vectordrawable/src/main/java/androidx/vectordrawable/graphics/drawable/VectorDrawableCommon.java
M vectordrawable/integration-tests/testapp/src/main/java/com/example/android/support/vectordrawable/app/AVDCListenerDemo.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/AnimationUtilsCompat.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/AnimatedVectorDrawableCompat.java
M vectordrawable/vectordrawable-animated/api/public_plus_experimental_current.txt
M vectordrawable/vectordrawable-animated/src/androidTest/java/androidx/vectordrawable/graphics/drawable/tests/AnimatedVectorDrawableTest.java

https://android-review.googlesource.com/2133639

Issue 236497996

Description

Issue summary

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Add comment

Issue metadata