[vectordrawable/vectordrawable-animated] Fix 10 suppressed lint issue(s) in `AnimatorInflaterCompat.java` [236498029]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 19, 2022 05:35AM

The following 10 lint issue(s) are suppressed in src/main/java/androidx/vectordrawable/graphics/drawable/AnimatorInflaterCompat.java. Please remove these suppressions in vectordrawable/vectordrawable-animated/lint-baseline.xml and address the associated issues.

Line number: 92
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, @AnimatorRes int id)
                  ~~~~~~~~

Line number: 92
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, @AnimatorRes int id)
                                        ~~~~~~~

Line number: 114
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                  ~~~~~~~~

Line number: 114
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                        ~~~~~~~

Line number: 114
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                                         ~~~~~~~~~

Line number: 114
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                                                              ~~~~~

Line number: 122
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                  ~~~~~~~~

Line number: 122
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                        ~~~~~~~

Line number: 122
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                                         ~~~~~~~~~

Line number: 122
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                                                              ~~~~~

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

Accepted by al...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit 822b94312ab0e71054dcf8c007d4d8b6ba61db98
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 06 16:09:13 2023

Refactor PagingDataDiffer PageEvent processing

Streamline the process in preparation for upcoming refactors

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: I809a5197633e9d7167388160509bec00566d7417

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagePresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt

https://android-review.googlesource.com/2871509

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit fb741839c9be2e2a0a9e023bbba3c0cbac3c9ebb
Author: Clara Fok <clarafok@google.com>
Date: Wed Dec 06 16:22:46 2023

Rename PagePresenter to PageStore

PageStore will be refactored to only process and store loaded data.

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: Ic3502d2a541e02355d65cc5154025a0301a50ec5

M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataDiffer.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageFetcherSnapshotStateTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageStoreTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/ProcessPageEventCallbackCapture.kt

https://android-review.googlesource.com/2871510

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3621927b29ae21d513ea12dc171bf795397b6a0a
Author: Clara Fok <clarafok@google.com>
Date: Fri Dec 08 14:19:41 2023

Rename PagingDataDiffer to PagingDataPresenter

Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Test: ./gradlew paging:paging-compose:cC
Bug: 315214786
Change-Id: I9e0c98ef8508c267c2d02ff64a40d698f9f10bb3

M paging/paging-common/src/commonJvmAndroidTest/kotlin/androidx/paging/PageFetcherTest.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/ViewportHint.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PageEventTest.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataDifferTest.kt
M paging/paging-compose/src/commonMain/kotlin/androidx/paging/compose/LazyPagingItems.kt
M paging/paging-guava/src/test/java/androidx/paging/ListenableFuturePagingDataTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
M paging/paging-rxjava2/src/test/java/androidx/paging/rxjava2/RxPagingDataTest.kt
M paging/paging-rxjava3/src/test/java/androidx/paging/rxjava3/RxPagingDataTest.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/LoadErrorHandler.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/PagerFlowSnapshot.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/SnapshotLoader.kt
M testutils/testutils-paging/src/commonMain/kotlin/androidx/paging/TestPagingDataPresenter.kt

https://android-review.googlesource.com/2871511

Issue 236498029

Description

Issue summary

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Add comment

Issue metadata