[vectordrawable/vectordrawable-animated] Fix 10 suppressed lint issue(s) in `AnimatorInflaterCompat.java` [236498029]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 19, 2022 05:35AM

The following 10 lint issue(s) are suppressed in src/main/java/androidx/vectordrawable/graphics/drawable/AnimatorInflaterCompat.java. Please remove these suppressions in vectordrawable/vectordrawable-animated/lint-baseline.xml and address the associated issues.

Line number: 92
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, @AnimatorRes int id)
                  ~~~~~~~~

Line number: 92
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, @AnimatorRes int id)
                                        ~~~~~~~

Line number: 114
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                  ~~~~~~~~

Line number: 114
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                        ~~~~~~~

Line number: 114
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                                         ~~~~~~~~~

Line number: 114
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                                                              ~~~~~

Line number: 122
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                  ~~~~~~~~

Line number: 122
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                        ~~~~~~~

Line number: 122
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                                         ~~~~~~~~~

Line number: 122
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public static Animator loadAnimator(Context context, Resources resources, Theme theme,
                                                                              ~~~~~

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

Accepted by al...@google.com.

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

Marked as fixed.

Thanks for the report!

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Issue 236498029

Description

Issue summary

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Add comment

Issue metadata