[vectordrawable/vectordrawable-animated] Fix 7 suppressed lint issue(s) in `PathInterpolatorCompat.java` [236498052]

Fixed

Bug

Status Update

No update yet.

Description

ti...@google.com

created issue #1

Jun 19, 2022 05:35AM

The following 7 lint issue(s) are suppressed in src/main/java/androidx/vectordrawable/graphics/drawable/PathInterpolatorCompat.java. Please remove these suppressions in vectordrawable/vectordrawable-animated/lint-baseline.xml and address the associated issues.

Line number: 67
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public PathInterpolatorCompat(Context context, AttributeSet attrs, XmlPullParser parser) {
                                  ~~~~~~~

Line number: 67
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public PathInterpolatorCompat(Context context, AttributeSet attrs, XmlPullParser parser) {
                                                   ~~~~~~~~~~~~

Line number: 67
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public PathInterpolatorCompat(Context context, AttributeSet attrs, XmlPullParser parser) {
                                                                       ~~~~~~~~~~~~~

Line number: 71
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public PathInterpolatorCompat(Resources res, Resources.Theme theme, AttributeSet attrs,
                                  ~~~~~~~~~

Line number: 71
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public PathInterpolatorCompat(Resources res, Resources.Theme theme, AttributeSet attrs,
                                                 ~~~~~~~~~~~~~~~

Line number: 71
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


    public PathInterpolatorCompat(Resources res, Resources.Theme theme, AttributeSet attrs,
                                                                        ~~~~~~~~~~~~

Line number: 72
Lint check ID: UnknownNullness
Lint message: Unknown nullability; explicitly declare as `@Nullable` or `@NonNull` to improve Kotlin interoperability; see https://developer.android.com/kotlin/interop#nullability_annotations


            XmlPullParser parser) {
            ~~~~~~~~~~~~~

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

Accepted by al...@google.com.

This is actually the intended behavior, the text overload was only intended for the simplest use case. Anything else requires the lambda API by design. Having discussed this further, the distinction between overloads is confusing though, and there isn't much value in just providing a string overload. As a result we plan to remove the string overload for Button, see how that goes, and then evaluate our overall 'string overload strategy' across other components.

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e386f97dd769da18d9f3103958714e43d797219f
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Fri Jan 31 17:32:33 2020

Monthly button refactoring

- Removes string overload for Button
- Replaces ButtonStyle with distinct functions, the following is the
migration strategy:

ContainedButtonStyle -> Button
OutlinedButtonStyle -> OutlinedButton
TextButtonStyle -> TextButton
Custom ButtonStyle -> Any / which ever is most semantically related

Now that each function takes the same parameters, and there are no
overloads, there is no more large separation between layers - extra
customization is just a matter of supplying more parameters, instead of
needing to find overloads / copy and paste parameters from high level
styles into the base ButtonStyle.

Also adds sample for Modifiers so the samples won't break when API
changes like this are made.

Bug:

b/146478620

Bug:

b/146482131

Bug:

b/146346551

Test: ButtonTest
Change-Id: If63ab32bd3f12050a2d2f4b8c0cb044bc7144a6b
Relnote: "Replaced ButtonStyle with distinct functions and removed text (string) overload. See updated samples for usage information."

M compose/compose-runtime/integration-tests/samples/src/main/java/androidx/compose/samples/EffectSamples.kt
M compose/compose-runtime/integration-tests/samples/src/main/java/androidx/compose/samples/ModelSamples.kt
M compose/compose-runtime/integration-tests/samples/src/main/java/androidx/compose/samples/RecomposeSamples.kt
M ui/ui-android-view/integration-tests/android-view-demos/src/main/java/androidx/ui/androidview/demos/ViewInCompose.kt
M ui/ui-core/integration-tests/samples/build.gradle
A ui/ui-core/integration-tests/samples/src/main/java/androidx/ui/core/samples/ModifierSamples.kt
M ui/ui-core/src/main/java/androidx/ui/core/Modifier.kt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/SemanticsL1.kt
M ui/ui-material/api/0.1.0-dev05.txt
M ui/ui-material/api/current.txt
M ui/ui-material/api/public_plus_experimental_0.1.0-dev05.txt
M ui/ui-material/api/public_plus_experimental_current.txt
M ui/ui-material/api/restricted_0.1.0-dev05.txt
M ui/ui-material/api/restricted_current.txt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ButtonActivity.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/CustomShapeActivity.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/TabActivity.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/RallyAlertDialog.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/RallyCards.kt
M ui/ui-material/integration-tests/samples/src/main/java/androidx/ui/material/samples/AlertDialogSample.kt
M ui/ui-material/integration-tests/samples/src/main/java/androidx/ui/material/samples/ButtonSamples.kt
M ui/ui-material/integration-tests/samples/src/main/java/androidx/ui/material/samples/DrawerSamples.kt
M ui/ui-material/integration-tests/samples/src/main/java/androidx/ui/material/samples/SnackbarSample.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Button.kt
M ui/ui-material/src/main/java/androidx/ui/material/Snackbar.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertExistsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CustomActivityTest.kt

https://android-review.googlesource.com/1222411

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit 07343ff52ec2a5b3fdd89e7a241c11e6b19a15fb
Author: Alan Viverette <alanv@google.com>
Date: Tue Jun 21 14:43:47 2022

Fix lint issues in vectordrawable-animated

Also fixes incorrect nullability annotation in core DrawableCompat.

Relnote: Updated nullability annotations
Fixes: 236498052
Fixes: 236498029
Fixes: 236497996
Fixes: 236497942
Fixes: 236497884
Test: vectordrawable-animation suite of tests
Fixes: 236497726
Change-Id: I34cce3c167135c9020a015b08f70fb1cdba5f8ce

M vectordrawable/vectordrawable-animated/api/current.txt
M vectordrawable/vectordrawable-animated/api/restricted_1.2.0-beta01.txt
M vectordrawable/vectordrawable-animated/api/public_plus_experimental_1.2.0-beta01.txt
M vectordrawable/vectordrawable-animated/build.gradle
M core/core/api/public_plus_experimental_current.txt
M vectordrawable/vectordrawable/src/main/java/androidx/vectordrawable/graphics/drawable/AndroidResources.java
M vectordrawable/vectordrawable-animated/src/androidTest/java/androidx/vectordrawable/graphics/drawable/tests/AnimatedVectorDrawableParameterizedTest.java
M core/core/api/current.txt
M core/core/src/main/java/androidx/core/graphics/drawable/DrawableCompat.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/Animatable2Compat.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/ArgbEvaluator.java
M vectordrawable/vectordrawable-animated/api/1.2.0-beta01.txt
M core/core/api/restricted_current.txt
M vectordrawable/vectordrawable-animated/api/restricted_current.txt
M vectordrawable/vectordrawable-animated/src/androidTest/java/androidx/vectordrawable/graphics/drawable/tests/PathInterpolatorParameterizedTest.java
M vectordrawable/vectordrawable/src/main/java/androidx/vectordrawable/graphics/drawable/VectorDrawableCommon.java
M vectordrawable/integration-tests/testapp/src/main/java/com/example/android/support/vectordrawable/app/AVDCListenerDemo.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/AnimationUtilsCompat.java
M vectordrawable/vectordrawable-animated/src/main/java/androidx/vectordrawable/graphics/drawable/AnimatedVectorDrawableCompat.java
M vectordrawable/vectordrawable-animated/api/public_plus_experimental_current.txt
M vectordrawable/vectordrawable-animated/src/androidTest/java/androidx/vectordrawable/graphics/drawable/tests/AnimatedVectorDrawableTest.java

https://android-review.googlesource.com/2133639

Issue 236498052

Description

Issue summary

Comments

al...@google.com <al...@google.com> #2Jun 21, 2022 06:45PM

al...@google.com <al...@google.com> #3Jun 23, 2022 03:08AM

ap...@google.com <ap...@google.com> #4Jun 28, 2022 09:36PM

Add comment

Issue metadata