BadgedBox may clip the Badge outside the bounds of the layout [236524516]

Fixed

Bug

Status Update

No update yet.

Description

jo...@gmail.com

created issue #1

Jun 20, 2022 09:40AM

Jetpack Compose version: 1.1.1
Jetpack Compose component used: 1.1.1

Android Studio Build:
Android Studio Chipmunk | 2021.2.1 Patch 1
Build #AI-212.5712.43.2112.8609683, built on May 18, 2022
Runtime version: 11.0.12+0-b1504.28-7817840 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.4
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 16
Registry: external.system.auto.import.disabled=true
Non-Bundled Plugins: com.yemreak.DarkCode-Theme (1.1), wu.seal.tool.jsontokotlin (3.7.4), com.suusan2go.kotlin-fill-class (1.0.12)

Kotlin version: 1.6.10

Using the BadgedBox should create a new layout with the main content and the badge places on top of it as per Material design guidelines.

The assumption is also that the new layout with the badge + content can be places inside other layouts and the layout bounds are set and both the badge + main content are inside the set layout.

However, the Badge is placed relative to the main content which means it can be placed over the layout and other Compose layouts cannot layout it properly inside the bounds and thus the BadgedBox can be clipped as a result of the parent layout.

I think the offending line is in BadgedBox function and the following lines:

val badgeY = -badgePlaceable.height / 2
badgePlaceable.placeRelative(badgeX, badgeY)

This moves the badge upwards without taking into account that it may clip the parent layout.

Comments

co...@google.com <co...@google.com> Jun 21, 2022 07:35PM

Reassigned to co...@google.com.

co...@google.com <co...@google.com> Jun 23, 2022 05:55PM

Accepted by co...@google.com.

co...@google.com <co...@google.com> Jul 26, 2022 07:13PM

Assigned to co...@google.com.

ap...@google.com <ap...@google.com> #2Jul 27, 2022 11:43AM

deleted

co...@google.com <co...@google.com> #3Jun 1, 2023 05:57PM

Marked as fixed, reassigned to ke...@google.com.

ph...@gmail.com <ph...@gmail.com> #4Aug 23, 2024 09:21AM

Project: platform/frameworks/support
Branch: androidx-main

commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Apr 11 14:38:58 2023

[M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet

Bug: 274872542
Bug: 272973615
Bug: 272334475
Bug: 268432129
Bug: 275849044
Bug: 275486106
Bug: 268433162
RelNote: Add window insets parameter to ModalBottomSheet.
RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
Test: Manual EdgeToEdge testing on various devices and android APIs
Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78

M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt

https://android-review.googlesource.com/2531428

Fri Aug 23 2024 16:17:47 GMT+0700 (Indochina Time).png

6.8 KB

View

Download

Issue 236524516