NPE in shrinker, R8 version 3.2.60 [236615030]

Verified

Bug

Status Update

No update yet.

Description

da...@spotify.com

created issue #1

Jun 21, 2022 12:52PM

When upgrading from R8 version 3.0.78 to 3.2.60, our minification starts failing with the following stack trace. Please let us know how to provide more information, if necessary.

Caused by: com.android.tools.r8.CompilationFailedException: Compilation failed to complete	
at Version.fakeStackEntry(Version_3.2.60.java:0)	
at com.android.tools.r8.internal.bi.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:68)	
at com.android.tools.r8.internal.bi.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:28)	
at com.android.tools.r8.internal.bi.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:27)	
at com.android.tools.r8.R8.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:29)	
at com.android.tools.r8.R8.run(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:3)	
at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:301)	
at com.android.build.gradle.internal.tasks.R8Task$Companion.shrink(R8Task.kt:592)	
at com.android.build.gradle.internal.tasks.R8Task.doTaskAction(R8Task.kt:443)	
at com.android.build.gradle.internal.tasks.NonIncrementalTask$taskAction$$inlined$recordTaskAction$1.invoke(BaseTask.kt:66)	
at com.android.build.gradle.internal.tasks.Blocks.recordSpan(Blocks.java:51)	
at com.android.build.gradle.internal.tasks.NonIncrementalTask.taskAction(NonIncrementalTask.kt:97)	
at jdk.internal.reflect.GeneratedMethodAccessor785.invoke(Unknown Source)
...
Caused by: java.lang.NullPointerException: (No message provided)	
at com.android.tools.r8.internal.jm.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:1)	
at com.android.tools.r8.internal.jm.add(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:1)	
at com.android.tools.r8.internal.gD.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:81)	
at com.android.tools.r8.internal.gD.b(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:2)	
at com.android.tools.r8.shaking.y.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:8518)	
at com.android.tools.r8.shaking.y.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:8332)	
at com.android.tools.r8.R8.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:2174)	
at com.android.tools.r8.R8.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:1039)	
at com.android.tools.r8.R8.c(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:1)	
at com.android.tools.r8.R8.b(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:1)	
at com.android.tools.r8.internal.bi.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:24)	
at com.android.tools.r8.R8.a(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:29)	
at com.android.tools.r8.R8.run(R8_3.2.60_61a204e00a4460bee78ec2913234dc5e1a3a501d9754e757835d117b7e302ba3:3)	
at com.android.builder.dexing.R8Tool.runR8(r8Tool.kt:301)
at com.android.build.gradle.internal.tasks.R8Task$Companion.shrink(R8Task.kt:592)	
at com.android.build.gradle.internal.tasks.R8Task.doTaskAction(R8Task.kt:443)	
at com.android.build.gradle.internal.tasks.NonIncrementalTask$taskAction$$inlined$recordTaskAction$1.invoke(BaseTask.kt:66)	
at com.android.build.gradle.internal.tasks.Blocks.recordSpan(Blocks.java:51)	
at com.android.build.gradle.internal.tasks.NonIncrementalTask.taskAction(NonIncrementalTask.kt:97)	
at jdk.internal.reflect.GeneratedMethodAccessor785.invoke(Unknown Source)
...

Comments

ch...@google.com <ch...@google.com> #2Jun 21, 2022 01:04PM

Fixed in r1313.

ch...@google.com <ch...@google.com> #3Jun 21, 2022 01:17PM

[Empty comment from Monorail migration]

sg...@google.com <sg...@google.com> Jun 21, 2022 01:55PM

Reassigned to ch...@google.com.

da...@spotify.com <da...@spotify.com> #4Jun 21, 2022 02:00PM

[Empty comment from Monorail migration]

ap...@google.com <ap...@google.com> #5Jun 22, 2022 01:02PM

This issue was migrated from

crbug.com/nativeclient/245?no_tracker_redirect=1

[Monorail components: TrustedRT]

da...@spotify.com <da...@spotify.com> #6Jun 22, 2022 01:07PM

Nice! Let me know which release I can test it against. Is it going into the 3.2.x branch?

ap...@google.com <ap...@google.com> #7Jun 22, 2022 02:08PM

Project: r8
Branch: 3.3

commit c0e7efd5845505e01b1ee44fb6b5d2dcd1761f6e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:33:58 2022

Version 3.3.63

Bug:

b/236615030

Change-Id: I19e9380714fee56e666c05bc99b247975e77f747

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/69258

ap...@google.com <ap...@google.com> #8Jun 22, 2022 02:08PM

Project: r8
Branch: 3.3

commit 03af92b0a390d7ce622e5554a7315edeb4421d1c
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:32:59 2022

Fix NPE from rewriting of missing classes contexts

Bug:

b/236615030

Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7

M src/main/java/com/android/tools/r8/shaking/MissingClasses.java

https://r8-review.googlesource.com/69257

ap...@google.com <ap...@google.com> #9Jun 22, 2022 02:08PM

Project: r8
Branch: 3.2

commit e63b2dac1dfd5ea22e3ec5e26fcb5534a4836c22
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:34:57 2022

Version 3.2.71

Bug:

b/236615030

Change-Id: Ic46f2a5a677408946de06c99e549d7f3e80f9282

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/69260

ap...@google.com <ap...@google.com> #10Jun 22, 2022 02:08PM

Project: r8
Branch: 3.2

commit e55131270b332d032c15cc067718fd348784bd86
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:34:20 2022

Fix NPE from rewriting of missing classes contexts

Bug:

b/236615030

Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7

M src/main/java/com/android/tools/r8/shaking/MissingClasses.java

https://r8-review.googlesource.com/69259

ap...@google.com <ap...@google.com> #11Jun 22, 2022 02:08PM

Project: r8
Branch: 3.1

commit 659ad95323dcda252c852b47817ec946d379c625
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:35:52 2022

Version 3.1.80

Bug:

b/236615030

Change-Id: I4eff1308d96a600cb816d4b610e1e5cf17e0c5c8

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/69262

ap...@google.com <ap...@google.com> #12Jun 22, 2022 02:08PM

Project: r8
Branch: 3.1

commit 4e672f5cb21059b5bafb32f2677e06008ac45568
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:35:17 2022

Fix NPE from rewriting of missing classes contexts

Bug:

b/236615030

Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7

M src/main/java/com/android/tools/r8/shaking/MissingClasses.java

https://r8-review.googlesource.com/69261

ap...@google.com <ap...@google.com> #13Jun 22, 2022 02:09PM

b/236615030

Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7

M src/main/java/com/android/tools/r8/shaking/MissingClasses.java

https://r8-review.googlesource.com/69257

ap...@google.com <ap...@google.com> #14Jun 22, 2022 02:09PM

b/236615030

Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7

M src/main/java/com/android/tools/r8/shaking/MissingClasses.java

https://r8-review.googlesource.com/69259

ap...@google.com <ap...@google.com> #15Jun 22, 2022 02:10PM

b/236615030

Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7

M src/main/java/com/android/tools/r8/shaking/MissingClasses.java

https://r8-review.googlesource.com/69257

ch...@google.com <ch...@google.com> #16Jun 22, 2022 02:10PM

Verified by ch...@google.com.

The fix should now be in R8 3.1.80, 3.2.71 and 3.3.63.

You can build with any R8 release version by adding the following to settings.gradle.

pluginManagement {
    buildscript {
        repositories {
            mavenCentral()
            maven {
                url = uri("https://storage.googleapis.com/r8-releases/raw")
            }
        }
        dependencies {
            classpath("com.android.tools:r8:3.2.71")
        }
    }
}

da...@spotify.com <da...@spotify.com> #17Jun 23, 2022 01:12PM

Thank you! I've verified that the fix works, but unfortunately it uncovered a secondary issue, which I'll open a separate bug report for.

ap...@google.com <ap...@google.com> #18Jun 27, 2022 02:56PM

Project: r8
Branch: main

commit 9d1c3c24d90d1aefc6aa4b71a9f0733d6ccda6fe
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:30:42 2022

Reproduce NPE from rewriting of missing classes contexts

Bug:

b/236615030

Change-Id: I66df15e802f060b2c58679455eb328022f30cdb7

A src/test/java/com/android/tools/r8/missingclasses/MissingClassReferencedFromForcefullyMovedMethodTest.java
M src/test/java/com/android/tools/r8/missingclasses/MissingClassesTestBase.java

https://r8-review.googlesource.com/69256

Issue 236615030

Description

Issue summary

Comments

ch...@google.com <ch...@google.com> #2Jun 21, 2022 01:04PM

ch...@google.com <ch...@google.com> #3Jun 21, 2022 01:17PM

sg...@google.com <sg...@google.com> Jun 21, 2022 01:55PM

da...@spotify.com <da...@spotify.com> #4Jun 21, 2022 02:00PM

ap...@google.com <ap...@google.com> #5Jun 22, 2022 01:02PM

da...@spotify.com <da...@spotify.com> #6Jun 22, 2022 01:07PM

ap...@google.com <ap...@google.com> #7Jun 22, 2022 02:08PM

ap...@google.com <ap...@google.com> #8Jun 22, 2022 02:08PM

ap...@google.com <ap...@google.com> #9Jun 22, 2022 02:08PM

ap...@google.com <ap...@google.com> #10Jun 22, 2022 02:08PM

ap...@google.com <ap...@google.com> #11Jun 22, 2022 02:08PM

ap...@google.com <ap...@google.com> #12Jun 22, 2022 02:08PM

ap...@google.com <ap...@google.com> #13Jun 22, 2022 02:09PM

ap...@google.com <ap...@google.com> #14Jun 22, 2022 02:09PM

ap...@google.com <ap...@google.com> #15Jun 22, 2022 02:10PM

ch...@google.com <ch...@google.com> #16Jun 22, 2022 02:10PM

da...@spotify.com <da...@spotify.com> #17Jun 23, 2022 01:12PM

ap...@google.com <ap...@google.com> #18Jun 27, 2022 02:56PM

Add comment

Issue metadata