Status Update
Comments
ch...@google.com <ch...@google.com> #2
Retraced stack trace:
Caused by: java.lang.NullPointerException: (No message provided)
at com.android.tools.r8.utils.collections.IdentityHashSetFromMap.lambda$newProgramDerivedContextSet$0(IdentityHashSetFromMap.java:26)
at com.android.tools.r8.utils.collections.IdentityHashSetFromMap.add(IdentityHashSetFromMap.java:62)
at com.android.tools.r8.shaking.MissingClasses$Builder.rewriteMissingClassContextsForSingleMissingClass(MissingClasses.java:214)
at com.android.tools.r8.shaking.MissingClasses$Builder.rewriteMissingClassContexts(MissingClasses.java:171)
at com.android.tools.r8.shaking.MissingClasses$Builder.getMissingClassesToBeReported(MissingClasses.java:233)
at com.android.tools.r8.shaking.MissingClasses$Builder.reportMissingClasses(MissingClasses.java:135)
at com.android.tools.r8.shaking.Enqueuer.createEnqueuerResult(Enqueuer.java:3767)
at com.android.tools.r8.shaking.Enqueuer.traceApplication(Enqueuer.java:3242)
at com.android.tools.r8.R8.runEnqueuer(R8.java:1026)
at com.android.tools.r8.R8.run(R8.java:382)
at com.android.tools.r8.R8.run(R8.java:265)
at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:256)
at com.android.tools.r8.utils.ExceptionUtils.withCompilationHandler(ExceptionUtils.java:80)
at com.android.tools.r8.utils.ExceptionUtils.withR8CompilationHandler(ExceptionUtils.java:69)
at com.android.tools.r8.R8.runForTesting(R8.java:252)
at com.android.tools.r8.R8.run(R8.java:190)
ch...@google.com <ch...@google.com> #3
Would it be possible for you to share a zip containing the inputs given to the compiler to allow reproducing this? You can generate such a dump by issuing the command ./gradlew assembleRelease --no-daemon -Dcom.android.tools.r8.dumpinputtodirectory=/path/to/dumps
. See also
You can share this privately with
sg...@google.com <sg...@google.com>
da...@spotify.com <da...@spotify.com> #4
A dump has been shared with both of you!
ap...@google.com <ap...@google.com> #5
Branch: main
commit a866fef498691f5193dc923a8965c8a6f6aded10
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 14:55:28 2022
Fix NPE from rewriting of missing classes contexts
Bug:
Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7
M src/main/java/com/android/tools/r8/shaking/MissingClasses.java
da...@spotify.com <da...@spotify.com> #6
Nice! Let me know which release I can test it against. Is it going into the 3.2.x branch?
ap...@google.com <ap...@google.com> #7
Branch: 3.3
commit c0e7efd5845505e01b1ee44fb6b5d2dcd1761f6e
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:33:58 2022
Version 3.3.63
Bug:
Change-Id: I19e9380714fee56e666c05bc99b247975e77f747
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #8
Branch: 3.3
commit 03af92b0a390d7ce622e5554a7315edeb4421d1c
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:32:59 2022
Fix NPE from rewriting of missing classes contexts
Bug:
Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7
M src/main/java/com/android/tools/r8/shaking/MissingClasses.java
ap...@google.com <ap...@google.com> #9
Branch: 3.2
commit e63b2dac1dfd5ea22e3ec5e26fcb5534a4836c22
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:34:57 2022
Version 3.2.71
Bug:
Change-Id: Ic46f2a5a677408946de06c99e549d7f3e80f9282
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #10
Branch: 3.2
commit e55131270b332d032c15cc067718fd348784bd86
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:34:20 2022
Fix NPE from rewriting of missing classes contexts
Bug:
Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7
M src/main/java/com/android/tools/r8/shaking/MissingClasses.java
ap...@google.com <ap...@google.com> #11
Branch: 3.1
commit 659ad95323dcda252c852b47817ec946d379c625
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:35:52 2022
Version 3.1.80
Bug:
Change-Id: I4eff1308d96a600cb816d4b610e1e5cf17e0c5c8
M src/main/java/com/android/tools/r8/Version.java
ap...@google.com <ap...@google.com> #12
Branch: 3.1
commit 4e672f5cb21059b5bafb32f2677e06008ac45568
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:35:17 2022
Fix NPE from rewriting of missing classes contexts
Bug:
Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7
M src/main/java/com/android/tools/r8/shaking/MissingClasses.java
ap...@google.com <ap...@google.com> #13
Branch: 3.3
commit 03af92b0a390d7ce622e5554a7315edeb4421d1c
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:32:59 2022
Fix NPE from rewriting of missing classes contexts
Bug:
Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7
M src/main/java/com/android/tools/r8/shaking/MissingClasses.java
ap...@google.com <ap...@google.com> #14
Branch: 3.2
commit e55131270b332d032c15cc067718fd348784bd86
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:34:20 2022
Fix NPE from rewriting of missing classes contexts
Bug:
Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7
M src/main/java/com/android/tools/r8/shaking/MissingClasses.java
ap...@google.com <ap...@google.com> #15
Branch: 3.3
commit 03af92b0a390d7ce622e5554a7315edeb4421d1c
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:32:59 2022
Fix NPE from rewriting of missing classes contexts
Bug:
Change-Id: Ib9d194d870ba79be2f8f704666100388fc8d0db7
M src/main/java/com/android/tools/r8/shaking/MissingClasses.java
ch...@google.com <ch...@google.com> #16
The fix should now be in R8 3.1.80, 3.2.71 and 3.3.63.
You can build with any R8 release version by adding the following to settings.gradle
.
pluginManagement {
buildscript {
repositories {
mavenCentral()
maven {
url = uri("https://storage.googleapis.com/r8-releases/raw")
}
}
dependencies {
classpath("com.android.tools:r8:3.2.71")
}
}
}
da...@spotify.com <da...@spotify.com> #17
Thank you! I've verified that the fix works, but unfortunately it uncovered a secondary issue, which I'll open a separate bug report for.
ap...@google.com <ap...@google.com> #18
Branch: main
commit 9d1c3c24d90d1aefc6aa4b71a9f0733d6ccda6fe
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Wed Jun 22 15:30:42 2022
Reproduce NPE from rewriting of missing classes contexts
Bug:
Change-Id: I66df15e802f060b2c58679455eb328022f30cdb7
A src/test/java/com/android/tools/r8/missingclasses/MissingClassReferencedFromForcefullyMovedMethodTest.java
M src/test/java/com/android/tools/r8/missingclasses/MissingClassesTestBase.java
Description
When upgrading from R8 version 3.0.78 to 3.2.60, our minification starts failing with the following stack trace. Please let us know how to provide more information, if necessary.