Move 1.5 along to stable [236866227]

Fixed

Process

adexe s nau

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 22, 2022 08:18PM

Need to get 1.5 into beta, then rc, etc. May get preempted by 1.6 upstream first, but we'll see!

Comments

al...@google.com <al...@google.com> Jun 27, 2022 08:19PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #2Jun 28, 2022 08:15PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

al...@google.com <al...@google.com> #3Jun 28, 2022 09:16PM

aosp/2136790 with a target release date of July 27th (yes that's the earliest release train).

al...@google.com <al...@google.com> #4Jun 29, 2022 02:44PM

Adding a one-off release for July 13th so we can get this out the door. Waiting on aosp/2136790 to land before we can schedule it.

al...@google.com <al...@google.com> #5Jun 29, 2022 02:44PM

Bugjuggler: wait until aosp/2136790 has merged

ap...@google.com <ap...@google.com> #6Jul 1, 2022 05:30PM

Project: platform/frameworks/support
Branch: androidx-main

commit d109cf3095fe175726b4300c9985d12cf53ed18a
Author: Alan Viverette <alanv@google.com>
Date: Mon Jun 27 16:19:11 2022

Finalize AppCompat, Emoji2, and ResourceInspection APIs for beta

Pins dependencies to latest stable or RC where applicable.

Relnote: Finalize AppCompat APIs for 1.5.0-beta01
Test: ./gradlew checkApi
Bug: 236866227
Merged-In: I2a43d45452aef36c958e780c0678b2f62738b1f1
Change-Id: I2a43d45452aef36c958e780c0678b2f62738b1f1

A emoji2/emoji2/api/res-1.2.0-beta01.txt
A appcompat/appcompat-resources/api/1.5.0-beta01.txt
A emoji2/emoji2-bundled/api/public_plus_experimental_1.2.0-beta01.txt
M appcompat/appcompat/build.gradle
A emoji2/emoji2-views/api/public_plus_experimental_1.2.0-beta01.txt
A emoji2/emoji2-views/api/res-1.2.0-beta01.txt
A emoji2/emoji2-views-helper/api/1.2.0-beta01.txt
M libraryversions.toml
A emoji2/emoji2-views/api/restricted_1.2.0-beta01.txt
A emoji2/emoji2-views-helper/api/public_plus_experimental_1.2.0-beta01.txt
A emoji2/emoji2-bundled/api/1.2.0-beta01.txt
A emoji2/emoji2/api/public_plus_experimental_1.2.0-beta01.txt
A appcompat/appcompat/api/res-1.5.0-beta01.txt
A appcompat/appcompat/api/public_plus_experimental_1.5.0-beta01.txt
A emoji2/emoji2-views-helper/api/restricted_1.2.0-beta01.txt
A resourceinspection/resourceinspection-annotation/api/1.1.0-beta01.txt
A appcompat/appcompat-resources/api/public_plus_experimental_1.5.0-beta01.txt
A emoji2/emoji2-bundled/api/restricted_1.2.0-beta01.txt
A resourceinspection/resourceinspection-annotation/api/restricted_1.1.0-beta01.txt
A appcompat/appcompat-resources/api/restricted_1.5.0-beta01.txt
A emoji2/emoji2/api/1.2.0-beta01.txt
A emoji2/emoji2/api/restricted_1.2.0-beta01.txt
A emoji2/emoji2-views/api/1.2.0-beta01.txt
A emoji2/emoji2-views-helper/api/res-1.2.0-beta01.txt
A resourceinspection/resourceinspection-annotation/api/public_plus_experimental_1.1.0-beta01.txt
A appcompat/appcompat-resources/api/res-1.5.0-beta01.txt
A appcompat/appcompat/api/restricted_1.5.0-beta01.txt
A appcompat/appcompat/api/1.5.0-beta01.txt
A emoji2/emoji2-bundled/api/res-1.2.0-beta01.txt

https://android-review.googlesource.com/2136790

al...@google.com <al...@google.com> #7Jul 8, 2022 08:09PM

Assigned to bu...@google.com.

Bugjuggler: wait until 2022-07-13

bu...@google.com <bu...@google.com> #8Jul 8, 2022 08:09PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait until 2022-07-13 00:00 -0400 EDT and then assign the bug to alanv@google.com.

al...@google.com <al...@google.com> #9Jul 11, 2022 08:57PM

Remaining work:

Bump appcompat and emoji2 to rc (needs downstream merge conflict resolution CL)
Check in prebuilts for emoji2 rc for use in appcompat release branch, pin dependency
Snap release branches
Schedule releases

ap...@google.com <ap...@google.com> #10Jul 12, 2022 06:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 129b70eb3bcac9843f55489f23fcd707242b93a5
Author: Alan Viverette <alanv@google.com>
Date: Mon Jul 11 16:42:21 2022

Move appcompat and emoji2 to rc01

Moves resourceinspection back to alpha01 since we didn't release it and
don't need to bump the version. Pins our KAPT dependency to match the
library version.

Bug: 236866227
Test: ./gradlew bOS
Merged-In: If7f50424437d4847d446722978e487bf1cd0f785
Change-Id: If7f50424437d4847d446722978e487bf1cd0f785

M libraryversions.toml
D resourceinspection/resourceinspection-annotation/api/1.1.0-beta01.txt
D resourceinspection/resourceinspection-annotation/api/public_plus_experimental_1.1.0-beta01.txt
M appcompat/appcompat/build.gradle
D resourceinspection/resourceinspection-annotation/api/restricted_1.1.0-beta01.txt

https://android-review.googlesource.com/2150316

al...@google.com <al...@google.com> #11Jul 12, 2022 06:21PM

I'm going to try and shortcut the prebuilts step because it's a lot of work. Remaining:

Wait for a green build in -main
Snap release branches
Schedule releases

al...@google.com <al...@google.com> #12Jul 12, 2022 08:31PM

Assigned to bu...@google.com.

rc01 releases scheduled.

Bugjuggler: wait until 2022-07-22

bu...@google.com <bu...@google.com> #13Jul 12, 2022 08:31PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait until 2022-07-22 00:00 -0400 EDT and then assign the bug to alanv@google.com.

bu...@google.com <bu...@google.com> Jul 22, 2022 04:02AM

Assigned to al...@google.com.

al...@google.com <al...@google.com> #14Jul 22, 2022 09:12PM

Accepted by al...@google.com.

Version bumps picked and builds kicked. Will schedule in Jetpad once we have green builds.

al...@google.com <al...@google.com> #15Jul 22, 2022 09:13PM

Next steps:

Wait for green builds on ab/8862027 and ab/8862031

al...@google.com <al...@google.com> #16Jul 25, 2022 03:20PM

Assigned to bu...@google.com.

Scheduled. Nothing to do now but wait.

Bugjuggler: wait until 2022-08-10

bu...@google.com <bu...@google.com> #17Jul 25, 2022 04:31PM

Accepted by bu...@google.com.

Hi. I've received your bug and will wait until 2022-08-10 00:00 -0400 EDT and then assign the bug to alanv@google.com.

bu...@google.com <bu...@google.com> Aug 10, 2022 04:00AM

Assigned to al...@google.com.

al...@google.com <al...@google.com> Aug 16, 2022 02:37PM

Marked as fixed.

na...@google.com <na...@google.com> #18Jan 11, 2023 08:12PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.emoji2:emoji2:1.3.0-alpha01
androidx.emoji2:emoji2-bundled:1.3.0-alpha01
androidx.emoji2:emoji2-views:1.3.0-alpha01
androidx.emoji2:emoji2-views-helper:1.3.0-alpha01

w6...@gmail.com <w6...@gmail.com> #19Jun 24, 2023 05:51AM

Waleed

Issue 236866227

Description

Issue summary

Comments

al...@google.com <al...@google.com> Jun 27, 2022 08:19PM

al...@google.com <al...@google.com> #2Jun 28, 2022 08:15PM

al...@google.com <al...@google.com> #3Jun 28, 2022 09:16PM

al...@google.com <al...@google.com> #4Jun 29, 2022 02:44PM

al...@google.com <al...@google.com> #5Jun 29, 2022 02:44PM

ap...@google.com <ap...@google.com> #6Jul 1, 2022 05:30PM

al...@google.com <al...@google.com> #7Jul 8, 2022 08:09PM

bu...@google.com <bu...@google.com> #8Jul 8, 2022 08:09PM

al...@google.com <al...@google.com> #9Jul 11, 2022 08:57PM

ap...@google.com <ap...@google.com> #10Jul 12, 2022 06:16PM

al...@google.com <al...@google.com> #11Jul 12, 2022 06:21PM

al...@google.com <al...@google.com> #12Jul 12, 2022 08:31PM

bu...@google.com <bu...@google.com> #13Jul 12, 2022 08:31PM

bu...@google.com <bu...@google.com> Jul 22, 2022 04:02AM

al...@google.com <al...@google.com> #14Jul 22, 2022 09:12PM

al...@google.com <al...@google.com> #15Jul 22, 2022 09:13PM

al...@google.com <al...@google.com> #16Jul 25, 2022 03:20PM

bu...@google.com <bu...@google.com> #17Jul 25, 2022 04:31PM

bu...@google.com <bu...@google.com> Aug 10, 2022 04:00AM

al...@google.com <al...@google.com> Aug 16, 2022 02:37PM

na...@google.com <na...@google.com> #18Jan 11, 2023 08:12PM

w6...@gmail.com <w6...@gmail.com> #19Jun 24, 2023 05:51AM

Add comment

Issue metadata