Verified
Status Update
Comments
ch...@google.com <ch...@google.com>
ch...@google.com <ch...@google.com> #2
Thanks for the excellent bug report!
ap...@google.com <ap...@google.com> #3
🥰
ap...@google.com <ap...@google.com> #4
Ime is not necessary part of repro, relayout does it.
@Composable
private fun TextCrash() {
val infiniteTransition = rememberInfiniteTransition(label = "infinite transition")
val padding by infiniteTransition.animateFloat(
initialValue = 0f,
targetValue = 50f,
animationSpec = infiniteRepeatable(tween(1000), RepeatMode.Reverse),
label = "I like to move it move it"
)
Box(
modifier = Modifier
.padding(padding.toInt().dp)
.fillMaxSize(),
contentAlignment = Alignment.Center
) {
Column(verticalArrangement = Arrangement.spacedBy(12.dp)) {
Text(
text = "Hello Android!".repeat(5),
textAlign = TextAlign.Center,
letterSpacing = 1.sp,
overflow = TextOverflow.Ellipsis,
maxLines = 1
)
}
}
}
ap...@google.com <ap...@google.com> #5
This is the minimal TextStyle to repro
ap...@google.com <ap...@google.com> #6
TextStyle(
textAlign = TextAlign.Center,
letterSpacing = 1.sp,
lineHeight = 24.sp,
lineHeightStyle = LineHeightStyle(
alignment = LineHeightStyle.Alignment.Center,
trim = LineHeightStyle.Trim.None,
mode = LineHeightStyle.Mode.Fixed
),
)
ap...@google.com <ap...@google.com> #7
Fix coming. Will see if I can get it into 1.8-beta01.
ap...@google.com <ap...@google.com> #8
Amazing! That was super quick)
ap...@google.com <ap...@google.com> #9
Excellent bug report and I had some idle cycles this week :)
ap...@google.com <ap...@google.com> #10
Project: r8
Branch: 3.3
commit 8c70ca559f60bb4144b21797a3ce2d47e7fc9502
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 24 13:49:57 2022
Fix invalid switch generation in switch optimizer
Bug: b/236875523
Change-Id: I06dc2405a9fefb1f7669fcdd65c4715cd4429036
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
https://r8-review.googlesource.com/69293
Branch: 3.3
commit 8c70ca559f60bb4144b21797a3ce2d47e7fc9502
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 24 13:49:57 2022
Fix invalid switch generation in switch optimizer
Bug:
Change-Id: I06dc2405a9fefb1f7669fcdd65c4715cd4429036
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
ap...@google.com <ap...@google.com> #11
Project: r8
Branch: 3.2
commit 8af601daca38f4d23cd3f50f90edcefe3fe4c363
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 24 13:52:58 2022
Fix invalid switch generation in switch optimizer
Bug: b/236875523
Change-Id: I06dc2405a9fefb1f7669fcdd65c4715cd4429036
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
https://r8-review.googlesource.com/69295
Branch: 3.2
commit 8af601daca38f4d23cd3f50f90edcefe3fe4c363
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 24 13:52:58 2022
Fix invalid switch generation in switch optimizer
Bug:
Change-Id: I06dc2405a9fefb1f7669fcdd65c4715cd4429036
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
ap...@google.com <ap...@google.com> #12
Project: r8
Branch: 3.3
commit 8c70ca559f60bb4144b21797a3ce2d47e7fc9502
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 24 13:49:57 2022
Fix invalid switch generation in switch optimizer
Bug: b/236875523
Change-Id: I06dc2405a9fefb1f7669fcdd65c4715cd4429036
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
https://r8-review.googlesource.com/69293
Branch: 3.3
commit 8c70ca559f60bb4144b21797a3ce2d47e7fc9502
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 24 13:49:57 2022
Fix invalid switch generation in switch optimizer
Bug:
Change-Id: I06dc2405a9fefb1f7669fcdd65c4715cd4429036
M src/main/java/com/android/tools/r8/ir/optimize/CodeRewriter.java
ch...@google.com <ch...@google.com> #13
This should be fixed in R8 versions 3.1.81, 3.2.72, and 3.3.66.
da...@spotify.com <da...@spotify.com> #14
I can confirm the fix works in 3.2.72. I haven't tested the other branches, but I have no reason to think they work differently. Thank you!
ch...@google.com <ch...@google.com> #15
Thanks for the confirmation, let us know if you run into any other issues!
ap...@google.com <ap...@google.com> #16
Project: r8
Branch: main
commit edeccdd850f166818249f2958075049d4f323003
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Jun 27 13:09:43 2022
Reproduce assertion failure from unresolvable method reference
Bug: b/236875523
Change-Id: I04c5c84ebb448e4862570999a44d72e6241c70c6
A src/test/java/com/android/tools/r8/classmerging/horizontal/UnresolvableMethodWithClassMergingTest.java
https://r8-review.googlesource.com/69323
Branch: main
commit edeccdd850f166818249f2958075049d4f323003
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Jun 27 13:09:43 2022
Reproduce assertion failure from unresolvable method reference
Bug:
Change-Id: I04c5c84ebb448e4862570999a44d72e6241c70c6
A src/test/java/com/android/tools/r8/classmerging/horizontal/UnresolvableMethodWithClassMergingTest.java
ap...@google.com <ap...@google.com> #17
Project: r8
Branch: main
commit 48f4f5304b3e3e600f23d2b6f7ce82e28a5219e4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Jun 27 13:11:37 2022
Soft-pin types referenced from unresolvable methods
Bug: b/236875523
Change-Id: I1d862f719172b1be6070308d101b7dca955a34ce
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/test/java/com/android/tools/r8/classmerging/horizontal/UnresolvableMethodWithClassMergingTest.java
https://r8-review.googlesource.com/69304
Branch: main
commit 48f4f5304b3e3e600f23d2b6f7ce82e28a5219e4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Mon Jun 27 13:11:37 2022
Soft-pin types referenced from unresolvable methods
Bug:
Change-Id: I1d862f719172b1be6070308d101b7dca955a34ce
M src/main/java/com/android/tools/r8/shaking/Enqueuer.java
M src/test/java/com/android/tools/r8/classmerging/horizontal/UnresolvableMethodWithClassMergingTest.java
Description
Got this failure on R8 versions 3.1.80 (and 3.2.71). The same input works for R8 version 3.0.78.
I'm sharing a dump zip privately.