Fixed
Status Update
Comments
ja...@appsfactory.de <ja...@appsfactory.de> #2
Lines for reference in ModalBottomSheet.android.kt
causing this behavior:
val newTarget = when (sheetState.anchoredDraggableState.targetValue) {
Hidden -> Hidden
PartiallyExpanded, Expanded -> {
val hasPartiallyExpandedState = newAnchors
.hasAnchorFor(PartiallyExpanded)
val newTarget = if (hasPartiallyExpandedState) PartiallyExpanded
else if (newAnchors.hasAnchorFor(Expanded)) Expanded else Hidden
newTarget
}
}
tr...@gmail.com <tr...@gmail.com> #3
My proposed solution would be:
val targetValue = sheetState.anchoredDraggableState.targetValue
val newTarget = when (targetValue) {
Hidden -> Hidden
PartiallyExpanded, Expanded -> {
when {
newAnchors.hasAnchorFor(targetValue)) -> targetValue
newAnchors.hasAnchorFor(PartiallyExpanded)) -> PartiallyExpanded
newAnchors.hasAnchorFor(Expanded)) -> Expanded
else -> Hidden
}
}
}
co...@google.com <co...@google.com>
sg...@google.com <sg...@google.com>
sg...@google.com <sg...@google.com> #4
Project: chromium/src
Branch: main
commit 0fe5e3c558992a1c0b5b2aef2594049862b1c703
Author: Zach Katz <katzz@google.com>
Date: Fri May 03 23:02:15 2024
[ASH] Add fieldtrial_testing_config
Bug: 324934884
Change-Id: Ib9d0ade90999a67cd74d1b94e6ab43087b5e1ead
Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5516358
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Zach Katz <katzz@google.com>
Cr-Commit-Position: refs/heads/main@{#1296421}
M testing/variations/fieldtrial_testing_config.json
https://chromium-review.googlesource.com/5516358
Branch: main
commit 0fe5e3c558992a1c0b5b2aef2594049862b1c703
Author: Zach Katz <katzz@google.com>
Date: Fri May 03 23:02:15 2024
[ASH] Add fieldtrial_testing_config
Bug: 324934884
Change-Id: Ib9d0ade90999a67cd74d1b94e6ab43087b5e1ead
Reviewed-on:
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Zach Katz <katzz@google.com>
Cr-Commit-Position: refs/heads/main@{#1296421}
M testing/variations/fieldtrial_testing_config.json
pr...@google.com <pr...@google.com> #6
any updates?
Description
Jetpack Compose version: 1.2.0-rc01 Jetpack Compose component used: CenterAlignedTopAppBar Kotlin version: 1.6.21
Description
A long title in a CenterAlignedTopAppBar overlaps the icons if their with is not identical on the left (navigation icon) and right (action icons) see screenshot.
Steps to Reproduce or Code Sample to Reproduce
Create a CenterAlignedTopAppBar with only a navigation icon and no action icons and a long title.
Since the TopAppBarLayout calculates the max width of the title by taking the full width of the bar, substracting the width of the nav icon and the action icons, but then centers it in the bar, it will overlap either the nav icon or the action icons - whichever of the both is wider.
Solution would be to take the max width of the navigation icon and the action icons and multiply it by 2 to have the same spacing on the left and right.