CenterAlignedTopAppBar title overlaps icons (Material3) [236994621]

Fixed

Bug

Status Update

No update yet.

Description

ja...@appsfactory.de

created issue #1

Jun 24, 2022 07:45AM

Jetpack Compose version: 1.2.0-rc01 Jetpack Compose component used: CenterAlignedTopAppBar Kotlin version: 1.6.21

Description

A long title in a CenterAlignedTopAppBar overlaps the icons if their with is not identical on the left (navigation icon) and right (action icons) see screenshot.

Steps to Reproduce or Code Sample to Reproduce

Create a CenterAlignedTopAppBar with only a navigation icon and no action icons and a long title.

CenterAlignedTopAppBar(
        title = {
            Text(
                text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Integer sodales",
                maxLines = 1,
                overflow = TextOverflow.Ellipsis
            )
        },
        navigationIcon = {
            if (navigationIcon != null) {
                IconButton(onClick = { onNavIconClick() }) {
                    Icon(
                        painter = ...,
                        contentDescription = null
                    )
                }
            }
        }
    )

Since the TopAppBarLayout calculates the max width of the title by taking the full width of the bar, substracting the width of the nav icon and the action icons, but then centers it in the bar, it will overlap either the nav icon or the action icons - whichever of the both is wider.

Solution would be to take the max width of the navigation icon and the action icons and multiply it by 2 to have the same spacing on the left and right.

Fri Jun 24 2022 09:34:03 GMT+0200 (Mitteleuropäische Sommerzeit).png

59 KB

View

Download

Comments

ja...@appsfactory.de <ja...@appsfactory.de> #2Jun 24, 2022 08:00AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

tr...@gmail.com <tr...@gmail.com> #3Sep 9, 2022 03:40PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

co...@google.com <co...@google.com> Sep 9, 2022 06:42PM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> Jun 5, 2023 10:05PM

Accepted by sg...@google.com.

sg...@google.com <sg...@google.com> #4Jun 6, 2023 03:34PM

Thanks for reporting this one, and thanks for the fix suggestion! Looks like the suggested fix works well. Since it will always try to center the title, it will also trim from the opposite site as well, which makes the visible title area smaller the more actions you have. We will apply a fix where we give some precedence to the title text over the center location. If the text is too long to be centered as a whole, we will shift it to fit as much as possible.

ap...@google.com <ap...@google.com> #5Jun 6, 2023 03:35PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 9f16ee04a9053a6028ffc90f152c1608cfeea8ae
Author: Shalom Gibly <sgibly@google.com>
Date: Mon Jun 05 18:52:14 2023

Fix the center top app bar alignment

Fix the alignement of the center top app bar to ensure its title does
not render over the icons when it's very long and the width of the
action icons is different than the width of the navigation icon.

This fix gives priority to the title's text display and shifts the title
from its center position as needed to show as much text as possible.

Fixes: 236994621
Test: AppBarTest & manual on LTR and RTL layouts
Relnote: "Fix the alignement of the center top app bar to ensure that a
long title doesn't render over the action icons or the navigation icon."

Change-Id: I4369f6c51c711129bb30b1de58684131b02499ae

M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/AppBarTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/AppBar.kt

https://android-review.googlesource.com/2616354

pr...@google.com <pr...@google.com> #6Jun 21, 2023 08:57PM