Fixed
Status Update
No update yet.
Comments
mg...@google.com
mg...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b42d44b2413ddba7b2a0b10a07aede97ceb1361c
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Apr 17 16:18:02 2024
Synchronize the creation of `ViewModel`
* Use `synchronized` to ensure `getViewModel` is thread-safe.
* Remove `@MainThread` from the public API.
* Delete unused `ViewModelProviderImpl` constructor.
* Remove dead code for log a warning, it has been introduced years ago and never acted upon.
* Rename constructor `extras` to `defaultExtras` and local `extras` to `modelExtras` to improve clarity and intention.
RelNote: "Creating a `ViewModel` with `ViewModelProvider` is now thread safe; `@MainThread` annotations have been removed."
Test: ViewModelTest
Fixes: 237006831
Change-Id: Ifd97842e103a029e1aeeeb5cd57dcb86b8770cf4
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt
M lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/ViewModelProviderImpl.kt
https://android-review.googlesource.com/3046594
Branch: androidx-main
commit b42d44b2413ddba7b2a0b10a07aede97ceb1361c
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Wed Apr 17 16:18:02 2024
Synchronize the creation of `ViewModel`
* Use `synchronized` to ensure `getViewModel` is thread-safe.
* Remove `@MainThread` from the public API.
* Delete unused `ViewModelProviderImpl` constructor.
* Remove dead code for log a warning, it has been introduced years ago and never acted upon.
* Rename constructor `extras` to `defaultExtras` and local `extras` to `modelExtras` to improve clarity and intention.
RelNote: "Creating a `ViewModel` with `ViewModelProvider` is now thread safe; `@MainThread` annotations have been removed."
Test: ViewModelTest
Fixes: 237006831
Change-Id: Ifd97842e103a029e1aeeeb5cd57dcb86b8770cf4
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/src/androidMain/kotlin/androidx/lifecycle/ViewModelProvider.android.kt
M lifecycle/lifecycle-viewmodel/src/commonMain/kotlin/androidx/lifecycle/viewmodel/internal/ViewModelProviderImpl.kt
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.lifecycle:lifecycle-viewmodel:2.9.0-alpha01androidx.lifecycle:lifecycle-viewmodel-android:2.9.0-alpha01androidx.lifecycle:lifecycle-viewmodel-desktop:2.9.0-alpha01androidx.lifecycle:lifecycle-viewmodel-iosarm64:2.9.0-alpha01androidx.lifecycle:lifecycle-viewmodel-iossimulatorarm64:2.9.0-alpha01androidx.lifecycle:lifecycle-viewmodel-iosx64:2.9.0-alpha01androidx.lifecycle:lifecycle-viewmodel-linuxx64:2.9.0-alpha01androidx.lifecycle:lifecycle-viewmodel-macosarm64:2.9.0-alpha01androidx.lifecycle:lifecycle-viewmodel-macosx64:2.9.0-alpha01
Description
Component used: Lifecycle
Version used: 2.5.0-rc02
Right now methods to create a
ViewModelare marked asMainThread. It would be nice if that limitation was removed andViewModelProvider(and hence the creation of ViewModels) could be made thread safe.This would be particularly helpful for cases such as with the Lifecycle ViewModel Compose API of
viewModel(), which would ensure future compatibility for multi-threaded composition.