Create themeing options for Glance [237012816]

Fixed

Feature Request

Status Update

No update yet.

Description

za...@google.com

created issue #1

Jun 23, 2022 11:26PM

Glance should support themeing that closely matches Material 3 style.

Comments

ap...@google.com <ap...@google.com> #2Jun 30, 2022 10:23PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

za...@google.com <za...@google.com> Sep 2, 2022 09:58PM

Reassigned to bb...@google.com.

ap...@google.com <ap...@google.com> #3Oct 6, 2022 09:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit 940388711a71240951ecf98041591fc7a89d8b59
Author: brenton.bade <bbade@google.com>
Date: Tue Sep 27 21:17:12 2022

[glance] Make DynamicThemeColorProviders an object

Bug: 237012816
Test: automated builds
Relnote: "Making dynamic theme ColorProviders its own object. Making
ResourceColorProvider internal to the module."

Change-Id: Id0e2db07ff278b7e4e64b23f8870b1ab6ea80391

M glance/glance/src/androidMain/kotlin/androidx/glance/color/ColorProviders.kt
M glance/glance/api/current.txt
M glance/glance/api/public_plus_experimental_current.txt
M glance/glance/api/restricted_current.txt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/template/GlanceTemplateAppWidget.kt
M glance/glance/src/test/kotlin/androidx/glance/color/ColorProvidersTest.kt

https://android-review.googlesource.com/2237333

ap...@google.com <ap...@google.com> #4Oct 18, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 39e8db05f0dd2f0fab705171abf8bf440ef69ec9
Author: brenton.bade <bbade@google.com>
Date: Wed Oct 05 00:40:17 2022

[glance] Set default text style to black.

Bug: 237012816
Test: presubmits
Relnote: Default text color to black. remove nullability

Change-Id: I3072ce2d5d6fcf98a6323e5d7f018bbf6bbac27e

M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverScreenshotTest.kt
M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverTest.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/TextTranslator.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/GlanceAppWidgetTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/GlanceRemoteViewsTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/RemoteViewsTranslatorKtTest.kt
M glance/glance-wear-tiles/src/androidAndroidTest/kotlin/androidx/glance/wear/tiles/ScreenshotTests.kt
M glance/glance-wear-tiles/src/androidMain/kotlin/androidx/glance/wear/tiles/WearCompositionTranslator.kt
M glance/glance/api/current.txt
M glance/glance/api/public_plus_experimental_current.txt
M glance/glance/api/restricted_current.txt
M glance/glance/src/androidMain/kotlin/androidx/glance/text/Text.kt
M glance/glance/src/androidMain/kotlin/androidx/glance/text/TextStyle.kt

https://android-review.googlesource.com/2238002

ap...@google.com <ap...@google.com> #5Oct 18, 2022 04:43PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit ed3f23bc5d5080a1cd1cc1e836b9919693734be7
Author: brenton.bade <bbade@google.com>
Date: Wed Sep 07 22:31:57 2022

Fix golden screenshot to match new default text style (black)

Bug: 237012816
Test: Presubmits

Change-Id: I87b2ae333ee1a25edb354e17adf68fba75e9f87d

M glance/glance-appwidget/alignment_cuttlefish.png
M glance/glance-appwidget/backgroundColor_cuttlefish.png
M glance/glance-appwidget/button_text_align_cuttlefish.png
M glance/glance-appwidget/fixed_top_level_size_cuttlefish.png
M glance/glance-appwidget/rowWidget_cuttlefish.png
M glance/glance-appwidget/rowWidget_rtl_cuttlefish.png
M glance/glance-appwidget/simpleAppWidget_cuttlefish.png
M glance/glance-appwidget/textAlignment_cuttlefish.png
M glance/glance-appwidget/textAlignment_rtl_cuttlefish.png
M glance/glance-appwidget/wrap_top_level_size_cuttlefish.png

https://android-review.googlesource.com/2210158

ap...@google.com <ap...@google.com> #6Oct 18, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 34dfad0e5d373ac078f09982ccab00d4a313b8ba
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:34:06 2022

[Glance Theme pt2] Apply glance theme to compound buttons

Test: Done manually on the final CL of this stack
Relnote: Apis related to color have changed.
Change-Id: I081aa7ffe1955570935fe04621b0ccad0a33fa95
Bug: 237012816

M glance/glance-appwidget/api/current.txt
M glance/glance-appwidget/api/public_plus_experimental_current.txt
M glance/glance-appwidget/api/restricted_current.txt
M glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/CompoundButtonAppWidget.kt
M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverScreenshotTest.kt
M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverTest.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/CheckBox.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/RadioButton.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/Switch.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/CheckBoxTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/CompoundButtonTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/RadioButtonTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/SwitchTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/unit/ColorProvider.kt
M glance/glance-appwidget/src/androidMain/res/color/glance_default_check_box.xml
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/CheckBoxTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/CompoundButtonTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/RadioButtonTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/SwitchTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/unit/ColorProviderTest.kt

https://android-review.googlesource.com/2205840

ap...@google.com <ap...@google.com> #7Oct 18, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2ac7e5f0d51f48ea267ec93e099c947869e7b98b
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:28:10 2022

[Glance Theme pt1] Add GlanceTheme and read its attributes in Button & Text

Bug: 237012816
Test: Manually ran all code in the stack, verified that the widget
closely matches a comparable layout in compose
Relnote: Removed nullability from Text(style: TextStyle)

Change-Id: I7123b0342ac50051847f3b88de905839593ad5db

M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverTest.kt
M glance/glance/api/current.txt
M glance/glance/api/public_plus_experimental_current.txt
M glance/glance/api/restricted_current.txt
M glance/glance/src/androidMain/kotlin/androidx/glance/Button.kt
M glance/glance/src/androidMain/kotlin/androidx/glance/CompositionLocals.kt
A glance/glance/src/androidMain/kotlin/androidx/glance/GlanceTheme.kt

https://android-review.googlesource.com/2205839

ap...@google.com <ap...@google.com> #8Oct 19, 2022 10:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 266e2ab15aece3b893a1557da22579f44f7fb1ff
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:39:07 2022

[Glance Theme pt4] Add demo widget for themes

Bug: 237012816
Test: Manually ran all code in the stack

Change-Id: I41b4b35269d8a3fa7dada9af282f7a26a500f586

M glance/glance-appwidget/integration-tests/demos/src/main/AndroidManifest.xml
A glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/DefaultColorsAppWidget.kt
M glance/glance-appwidget/integration-tests/demos/src/main/res/values/strings.xml
M glance/glance-appwidget/integration-tests/demos/src/main/res/values/styles.xml

https://android-review.googlesource.com/2205842

za...@google.com <za...@google.com> Dec 12, 2022 08:09PM

Marked as fixed.

na...@google.com <na...@google.com> #9May 10, 2023 07:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.glance:glance:1.0.0-beta01