Create themeing options for Glance [237012816]

Fixed

Feature Request

Status Update

No update yet.

Description

za...@google.com

created issue #1

Jun 23, 2022 11:26PM

Glance should support themeing that closely matches Material 3 style.

Comments

ap...@google.com <ap...@google.com> #2Jun 30, 2022 10:23PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

za...@google.com <za...@google.com> Sep 2, 2022 09:58PM

Reassigned to bb...@google.com.

ap...@google.com <ap...@google.com> #3Oct 6, 2022 09:19PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ap...@google.com <ap...@google.com> #4Oct 18, 2022 04:43PM

deleted

ap...@google.com <ap...@google.com> #5Oct 18, 2022 04:43PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ap...@google.com <ap...@google.com> #6Oct 18, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 34dfad0e5d373ac078f09982ccab00d4a313b8ba
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:34:06 2022

[Glance Theme pt2] Apply glance theme to compound buttons

Test: Done manually on the final CL of this stack
Relnote: Apis related to color have changed.
Change-Id: I081aa7ffe1955570935fe04621b0ccad0a33fa95
Bug: 237012816

M glance/glance-appwidget/api/current.txt
M glance/glance-appwidget/api/public_plus_experimental_current.txt
M glance/glance-appwidget/api/restricted_current.txt
M glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/CompoundButtonAppWidget.kt
M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverScreenshotTest.kt
M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverTest.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/CheckBox.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/RadioButton.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/Switch.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/CheckBoxTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/CompoundButtonTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/RadioButtonTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/SwitchTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/unit/ColorProvider.kt
M glance/glance-appwidget/src/androidMain/res/color/glance_default_check_box.xml
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/CheckBoxTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/CompoundButtonTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/RadioButtonTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/SwitchTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/unit/ColorProviderTest.kt

https://android-review.googlesource.com/2205840

ap...@google.com <ap...@google.com> #7Oct 18, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2ac7e5f0d51f48ea267ec93e099c947869e7b98b
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:28:10 2022

[Glance Theme pt1] Add GlanceTheme and read its attributes in Button & Text

Bug: 237012816
Test: Manually ran all code in the stack, verified that the widget
closely matches a comparable layout in compose
Relnote: Removed nullability from Text(style: TextStyle)

Change-Id: I7123b0342ac50051847f3b88de905839593ad5db

M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverTest.kt
M glance/glance/api/current.txt
M glance/glance/api/public_plus_experimental_current.txt
M glance/glance/api/restricted_current.txt
M glance/glance/src/androidMain/kotlin/androidx/glance/Button.kt
M glance/glance/src/androidMain/kotlin/androidx/glance/CompositionLocals.kt
A glance/glance/src/androidMain/kotlin/androidx/glance/GlanceTheme.kt

https://android-review.googlesource.com/2205839

ap...@google.com <ap...@google.com> #8Oct 19, 2022 10:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 266e2ab15aece3b893a1557da22579f44f7fb1ff
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:39:07 2022

[Glance Theme pt4] Add demo widget for themes

Bug: 237012816
Test: Manually ran all code in the stack

Change-Id: I41b4b35269d8a3fa7dada9af282f7a26a500f586

M glance/glance-appwidget/integration-tests/demos/src/main/AndroidManifest.xml
A glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/DefaultColorsAppWidget.kt
M glance/glance-appwidget/integration-tests/demos/src/main/res/values/strings.xml
M glance/glance-appwidget/integration-tests/demos/src/main/res/values/styles.xml

https://android-review.googlesource.com/2205842

za...@google.com <za...@google.com> Dec 12, 2022 08:09PM

Marked as fixed.

na...@google.com <na...@google.com> #9May 10, 2023 07:09PM