Create themeing options for Glance [237012816]

Fixed

Feature Request

Status Update

No update yet.

Description

za...@google.com

created issue #1

Jun 23, 2022 11:26PM

Glance should support themeing that closely matches Material 3 style.

Comments

ap...@google.com <ap...@google.com> #2Jun 30, 2022 10:23PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

za...@google.com <za...@google.com> Sep 2, 2022 09:58PM

Reassigned to bb...@google.com.

ap...@google.com <ap...@google.com> #3Oct 6, 2022 09:19PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

ap...@google.com <ap...@google.com> #4Oct 18, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

ap...@google.com <ap...@google.com> #5Oct 18, 2022 04:43PM

Project: platform/frameworks/support-golden
Branch: androidx-main

commit ed3f23bc5d5080a1cd1cc1e836b9919693734be7
Author: brenton.bade <bbade@google.com>
Date: Wed Sep 07 22:31:57 2022

Fix golden screenshot to match new default text style (black)

Bug: 237012816
Test: Presubmits

Change-Id: I87b2ae333ee1a25edb354e17adf68fba75e9f87d

M glance/glance-appwidget/alignment_cuttlefish.png
M glance/glance-appwidget/backgroundColor_cuttlefish.png
M glance/glance-appwidget/button_text_align_cuttlefish.png
M glance/glance-appwidget/fixed_top_level_size_cuttlefish.png
M glance/glance-appwidget/rowWidget_cuttlefish.png
M glance/glance-appwidget/rowWidget_rtl_cuttlefish.png
M glance/glance-appwidget/simpleAppWidget_cuttlefish.png
M glance/glance-appwidget/textAlignment_cuttlefish.png
M glance/glance-appwidget/textAlignment_rtl_cuttlefish.png
M glance/glance-appwidget/wrap_top_level_size_cuttlefish.png

https://android-review.googlesource.com/2210158

ap...@google.com <ap...@google.com> #6Oct 18, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 34dfad0e5d373ac078f09982ccab00d4a313b8ba
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:34:06 2022

[Glance Theme pt2] Apply glance theme to compound buttons

Test: Done manually on the final CL of this stack
Relnote: Apis related to color have changed.
Change-Id: I081aa7ffe1955570935fe04621b0ccad0a33fa95
Bug: 237012816

M glance/glance-appwidget/api/current.txt
M glance/glance-appwidget/api/public_plus_experimental_current.txt
M glance/glance-appwidget/api/restricted_current.txt
M glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/CompoundButtonAppWidget.kt
M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverScreenshotTest.kt
M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverTest.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/CheckBox.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/RadioButton.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/Switch.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/CheckBoxTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/CompoundButtonTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/RadioButtonTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/translators/SwitchTranslator.kt
M glance/glance-appwidget/src/androidMain/kotlin/androidx/glance/appwidget/unit/ColorProvider.kt
M glance/glance-appwidget/src/androidMain/res/color/glance_default_check_box.xml
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/CheckBoxTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/CompoundButtonTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/RadioButtonTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/translators/SwitchTranslatorTest.kt
M glance/glance-appwidget/src/test/kotlin/androidx/glance/appwidget/unit/ColorProviderTest.kt

https://android-review.googlesource.com/2205840

ap...@google.com <ap...@google.com> #7Oct 18, 2022 04:43PM

Project: platform/frameworks/support
Branch: androidx-main

commit 2ac7e5f0d51f48ea267ec93e099c947869e7b98b
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:28:10 2022

[Glance Theme pt1] Add GlanceTheme and read its attributes in Button & Text

Bug: 237012816
Test: Manually ran all code in the stack, verified that the widget
closely matches a comparable layout in compose
Relnote: Removed nullability from Text(style: TextStyle)

Change-Id: I7123b0342ac50051847f3b88de905839593ad5db

M glance/glance-appwidget/src/androidAndroidTest/kotlin/androidx/glance/appwidget/GlanceAppWidgetReceiverTest.kt
M glance/glance/api/current.txt
M glance/glance/api/public_plus_experimental_current.txt
M glance/glance/api/restricted_current.txt
M glance/glance/src/androidMain/kotlin/androidx/glance/Button.kt
M glance/glance/src/androidMain/kotlin/androidx/glance/CompositionLocals.kt
A glance/glance/src/androidMain/kotlin/androidx/glance/GlanceTheme.kt

https://android-review.googlesource.com/2205839

ap...@google.com <ap...@google.com> #8Oct 19, 2022 10:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit 266e2ab15aece3b893a1557da22579f44f7fb1ff
Author: brenton.bade <bbade@google.com>
Date: Fri Sep 02 20:39:07 2022

[Glance Theme pt4] Add demo widget for themes

Bug: 237012816
Test: Manually ran all code in the stack

Change-Id: I41b4b35269d8a3fa7dada9af282f7a26a500f586

M glance/glance-appwidget/integration-tests/demos/src/main/AndroidManifest.xml
A glance/glance-appwidget/integration-tests/demos/src/main/java/androidx/glance/appwidget/demos/DefaultColorsAppWidget.kt
M glance/glance-appwidget/integration-tests/demos/src/main/res/values/strings.xml
M glance/glance-appwidget/integration-tests/demos/src/main/res/values/styles.xml

https://android-review.googlesource.com/2205842

za...@google.com <za...@google.com> Dec 12, 2022 08:09PM

Marked as fixed.

na...@google.com <na...@google.com> #9May 10, 2023 07:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.glance:glance:1.0.0-beta01