Allow read-only access to consumed insets [237019262]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Jun 24, 2022 04:00PM

Jetpack Compose version: 1.2.0-rc02

Jetpack Compose component(s) used: Foundation

Android Studio Build: #AI-221.4165.146.2211.8713749

Kotlin version: 1.6.21

When accessing the window insets via asPaddingValues() it does not account for the already consumed insets further in the hierarchy. E.g.

   Box(
        modifier = Modifier
            .consumedWindowInsets(WindowInsets.navigationBars)
    ) {
        // will have non-zero insets
        val insets = WindowInsets.navigationBars.asPaddingValues()
    }

The PaddingValues could be added to a LazyColumn or similar layout that need extra padding, but only when a parent has not already consumed them. As far as I can tell it is not possible to access the amount of consumed insets, which makes it difficult to achieve this kind of layout.

My feature request is either having asPaddingValues already account for the consumed insets (just like Modifier.navigationBarPadding()) or at least provide read-only access to the amount of consumed insets.

Comments

ma...@google.com <ma...@google.com> Jun 27, 2022 10:38AM

Reassigned to mo...@google.com.

mo...@google.com <mo...@google.com> #2Jun 27, 2022 05:12PM

The attached Build Scan log shows that the emulator process crashed unexpectedly. Could you rerun your task with --info and -Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true to get more information about the emualtor process logs?

sa...@gmail.com <sa...@gmail.com> #3Jun 27, 2022 05:42PM

https://scans.gradle.com/s/llyxjwf4ipuzc

mo...@google.com <mo...@google.com> #4Jun 27, 2022 07:45PM

No idea why the scan does not contain log information, here you are: https://productionresultssa13.blob.core.windows.net/actions-results/3ec7e316-56eb-4f55-a7dd-511a2f3cf729/workflow-job-run-2623c0b7-dd66-5503-5665-c65c84dbf243/logs/job/job-logs.txt?rsct=text%2Fplain&se=2024-04-02T20%3A32%3A33Z&sig=Z1BPg7s513VC7nKkyGYEmknivAGxlX3Kdx0NsX%2BttW8%3D&sp=r&spr=https&sr=b&st=2024-04-02T20%3A22%3A28Z&sv=2021-12-02

va...@google.com <va...@google.com> #5Aug 17, 2022 03:57PM

The link in comment#4 seems not to be working for me. I got "AuthenticationFailed" error. If you run task with those --info and -Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true, the emulator process output its kernel logging to stdout. Do you see any stacktrace or segfault in the log?

mo...@google.com <mo...@google.com> #6Aug 29, 2022 11:25PM

That's strange, the repo and the build is public... But I attached the logs as file

ap...@google.com <ap...@google.com> #7Sep 1, 2022 06:07PM

Marked as fixed.

I looked into the logs and it turns out, the runner didn't have enough disk space. I guess the root cause is the Gradle update causing another Gradle major version (and its new transform-4) folder to cache was too much. Anyway, a better error message of the exit code of GMD would be helpful.

na...@google.com <na...@google.com> #8Sep 21, 2022 05:54PM

Thanks for uploading the log! Yes, the emulator kernel log says the issue was the insufficient disk space: 2024-04-02T18:31:45.7078429Z ERROR | Not enough space to create userdata partition. Available: 7177.027344 MB at /home/runner/.config/.android/avd/gradle-managed/dev34_aosp_atd_x86_64_Pixel_2.avd, need 7372.800000 MB.

Also, I agreed that GMD should diagnose errors and can provide better messages.

Let me rename this issue's title to improve the error message for disk space error.