Allow read-only access to consumed insets [237019262]

Fixed

Bug

Status Update

No update yet.

Description

sa...@gmail.com

created issue #1

Jun 24, 2022 04:00PM

Jetpack Compose version: 1.2.0-rc02

Jetpack Compose component(s) used: Foundation

Android Studio Build: #AI-221.4165.146.2211.8713749

Kotlin version: 1.6.21

When accessing the window insets via asPaddingValues() it does not account for the already consumed insets further in the hierarchy. E.g.

   Box(
        modifier = Modifier
            .consumedWindowInsets(WindowInsets.navigationBars)
    ) {
        // will have non-zero insets
        val insets = WindowInsets.navigationBars.asPaddingValues()
    }

The PaddingValues could be added to a LazyColumn or similar layout that need extra padding, but only when a parent has not already consumed them. As far as I can tell it is not possible to access the amount of consumed insets, which makes it difficult to achieve this kind of layout.

My feature request is either having asPaddingValues already account for the consumed insets (just like Modifier.navigationBarPadding()) or at least provide read-only access to the amount of consumed insets.

Comments

ma...@google.com <ma...@google.com> Jun 27, 2022 10:38AM

Reassigned to mo...@google.com.

mo...@google.com <mo...@google.com> #2Jun 27, 2022 05:12PM

Project: platform/frameworks/support
Branch: androidx-main

commit cb1afd67dacbf14cd22206c6f5b543dbf18cec1f
Author: Tony Mak <tonymak@google.com>
Date: Thu Jan 06 14:52:58 2022

Deprecate all the APIs in textclassifier

Bug: 210509084

Test: Check api/current.txt and ensure all classes are deprecated

Relnote: "Deprecate all the APIs in the textclassifier module"

Change-Id: Idc18063196531c0e926162fefeadf2dc5f559da1

M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextSelection.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinks.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationSessionId.java
M textclassifier/textclassifier/api/public_plus_experimental_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassification.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationManager.java
M textclassifier/textclassifier/api/current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassificationContext.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextLinksParams.java
M textclassifier/textclassifier/api/restricted_current.txt
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationAction.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/TextClassifier.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ConversationActions.java
M textclassifier/textclassifier/src/main/java/androidx/textclassifier/ExtrasUtils.java

https://android-review.googlesource.com/1938773

sa...@gmail.com <sa...@gmail.com> #3Jun 27, 2022 05:42PM

Is there any update when the alpha04 will be available? We need it to target api 31 because of the PendingIntent mutability flags missing in alpha03.

mo...@google.com <mo...@google.com> #4Jun 27, 2022 07:45PM

I'll schedule it for the next release. Note that alpha04 is a complete turn-down of the library where all APIs are marked as Deprecated, so you'll also want to start removing your usages of the library.

va...@google.com <va...@google.com> #5Aug 17, 2022 03:57PM

Project: platform/frameworks/support
Branch: androidx-main

commit 19ed7e69823a09f3c63f8c8cdf339af8ca1645ab
Author: Alan Viverette <alanv@google.com>
Date: Mon Mar 14 15:18:16 2022

Bump textclassifier for final release and turn-down

Bug: 210509084
Change-Id: Ib8b2386903bb49baa3211f7de7fe1587fdda1483
Test: ./gradlew checkApi

M libraryversions.toml

https://android-review.googlesource.com/2024823

mo...@google.com <mo...@google.com> #6Aug 29, 2022 11:25PM

Bugjuggler: wait until 2022-03-23

ap...@google.com <ap...@google.com> #7Sep 1, 2022 06:07PM

Marked as fixed.

Hi. I've received your bug and will wait until 2022-03-23 00:00 -0400 EDT and then assign the bug to alanv@google.com.

na...@google.com <na...@google.com> #8Sep 21, 2022 05:54PM

Is there a replacement or should we just abandon TextClassifier for android older than API Level 26 ?