Fixed
Status Update
Comments
st...@gmail.com <st...@gmail.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
ow...@google.com <ow...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #4
deleted
jb...@google.com <jb...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
l....@gmail.com <l....@gmail.com> #6
#5 any chance to have the fix backported to 2.5.x? 2.6.x stable is pretty far out if it's just going to alpha, which means we'll be stuck on 2.3.x until 2023 🙁
na...@google.com <na...@google.com> #7
This bug was linked in a change in the following release(s):
androidx.navigation:navigation-fragment:2.6.0-alpha01
androidx.navigation:navigation-fragment:2.5.2
am...@gmail.com <am...@gmail.com> #8
is this fixed? I am still facing issue with 2.6.0-alpha04. Unable to launch new instance of fragment
am...@gmail.com <am...@gmail.com> #9
even after using app:launchSingleTop="false" new instance of fragment is not created
Description
Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): androidx.navigation:navigation-ui-ktx, androidx.navigation:navigation-fragment-ktx
Version used: 2.4.2 Theme used: Devices/Android versions reproduced on: Pixel XL emulator / API 30
Relevant code to trigger the issue.https://github.com/rahobbs/NavExperiments
I'm updating Jetpack Navigation from 2.3.4 to 2.4.2 and believe I have found a breaking change in my project.
Let's say I have a MainFragment and a SecondFragment. Launching SecondFragment from MainFragment (with safeArgs) works as expected. However, I also need to be able to launch a new instance of SecondFragment from SecondFragment with new arguments. I'm constructing a new navigation action and telling the navController to navigate to it. Before updating, I could see that this navigation action was taken, and I hit onCreateView and other lifecycle methods in my SecondFragment class.
Now with the update, my log statement there is being logged and is correct, but it seems like the navigation action never happens, as I'm never hitting onCreateView or onViewCreated, and my SecondFragment does not update with the new arguments.
I have a small reproducible example here:https://github.com/rahobbs/NavExperiments/tree/main/app/src/main/java/com/example/navexperiments