Unable to navigate to a new instance of the same Fragment type after Jetpack Navigation 2.4.x update [237374580]

Fixed

Bug

Status Update

No update yet.

Description

ho...@gmail.com

created issue #1

Jun 28, 2022 01:57PM

Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): androidx.navigation:navigation-ui-ktx, androidx.navigation:navigation-fragment-ktx

Version used: 2.4.2 Theme used: Devices/Android versions reproduced on: Pixel XL emulator / API 30

Relevant code to trigger the issue. https://github.com/rahobbs/NavExperiments

I'm updating Jetpack Navigation from 2.3.4 to 2.4.2 and believe I have found a breaking change in my project.

Let's say I have a MainFragment and a SecondFragment. Launching SecondFragment from MainFragment (with safeArgs) works as expected. However, I also need to be able to launch a new instance of SecondFragment from SecondFragment with new arguments. I'm constructing a new navigation action and telling the navController to navigate to it. Before updating, I could see that this navigation action was taken, and I hit onCreateView and other lifecycle methods in my SecondFragment class.

override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
    super.onViewCreated(view, savedInstanceState)
    val button = view.findViewById<Button>(R.id.myButton)

    button.setOnClickListener {
        val action = SecondFragmentDirections.newSecondFragment("coming from second")
        Log.d("SecondFragment", "click ${action.arguments.get("myArg")}")
        findNavController().navigate(action)
    }

    val text = view.findViewById<TextView>(R.id.message)
    text.text = safeArgs.myArg
}

Now with the update, my log statement there is being logged and is correct, but it seems like the navigation action never happens, as I'm never hitting onCreateView or onViewCreated, and my SecondFragment does not update with the new arguments.

I have a small reproducible example here: https://github.com/rahobbs/NavExperiments/tree/main/app/src/main/java/com/example/navexperiments

Comments

st...@gmail.com <st...@gmail.com> #2Jul 7, 2022 12:24PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

ow...@google.com <ow...@google.com> #3Jul 8, 2022 10:49AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

il...@google.com <il...@google.com> Jul 13, 2022 11:49PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Aug 24, 2022 12:04AM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

jb...@google.com <jb...@google.com> #5Aug 24, 2022 12:14AM

Marked as fixed.

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

l....@gmail.com <l....@gmail.com> #6Aug 24, 2022 09:01PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

na...@google.com <na...@google.com> #7Sep 12, 2022 05:52PM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

am...@gmail.com <am...@gmail.com> #8Dec 9, 2022 10:43PM

Thank you, I'll try it and check.

am...@gmail.com <am...@gmail.com> #9Dec 9, 2022 10:44PM

Hello. I have similar experience.

I'm using mlkit-language 16.1.1
I didnot meet this error until using AGP 4.2
I can get this error since using AGP 7.0
This error raised on Release build only(minimized by R8)
This error raised without obfuscation.