Fixed
Status Update
Comments
st...@gmail.com <st...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
ow...@google.com <ow...@google.com> #3
since it is already marked as deprecated, we can probably do it by now.
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #4
Opening diff shortly
jb...@google.com <jb...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
l....@gmail.com <l....@gmail.com> #6
#5 any chance to have the fix backported to 2.5.x? 2.6.x stable is pretty far out if it's just going to alpha, which means we'll be stuck on 2.3.x until 2023 🙁
na...@google.com <na...@google.com> #7
This bug was linked in a change in the following release(s):
androidx.navigation:navigation-fragment:2.6.0-alpha01
androidx.navigation:navigation-fragment:2.5.2
am...@gmail.com <am...@gmail.com> #8
is this fixed? I am still facing issue with 2.6.0-alpha04. Unable to launch new instance of fragment
am...@gmail.com <am...@gmail.com> #9
even after using app:launchSingleTop="false" new instance of fragment is not created
Description
Artifact used (ex. androidx.appcompat:appcompat:1.0.0-alpha1): androidx.navigation:navigation-ui-ktx, androidx.navigation:navigation-fragment-ktx
Version used: 2.4.2 Theme used: Devices/Android versions reproduced on: Pixel XL emulator / API 30
Relevant code to trigger the issue.https://github.com/rahobbs/NavExperiments
I'm updating Jetpack Navigation from 2.3.4 to 2.4.2 and believe I have found a breaking change in my project.
Let's say I have a MainFragment and a SecondFragment. Launching SecondFragment from MainFragment (with safeArgs) works as expected. However, I also need to be able to launch a new instance of SecondFragment from SecondFragment with new arguments. I'm constructing a new navigation action and telling the navController to navigate to it. Before updating, I could see that this navigation action was taken, and I hit onCreateView and other lifecycle methods in my SecondFragment class.
Now with the update, my log statement there is being logged and is correct, but it seems like the navigation action never happens, as I'm never hitting onCreateView or onViewCreated, and my SecondFragment does not update with the new arguments.
I have a small reproducible example here:https://github.com/rahobbs/NavExperiments/tree/main/app/src/main/java/com/example/navexperiments