Status Update
Comments
al...@gmail.com <al...@gmail.com> #2
Branch: androidx-main
commit f0dc0968ae703e34aba39b2c6c836077c340d2a5
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Sep 01 15:34:41 2021
Make argument default params last
When generating an argument in kotlin from safe args, default parameters
should always come after none defaults in the argument's constructor.
RelNote: "When generating arguments, safe args now puts parameters
without default values before those with default values."
Test: ./gradlew --rerun-tasks
navigation:navigation-safe-args-generator:test
Bug: 198493585
Change-Id: I8970968c48deb3a1437437df9a3db696ed497372
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/MainFragmentArgs.kt
al...@gmail.com <al...@gmail.com> #3
This has been fixed internally and will be available in the Navigation 2.4.0-alpha09
release.
jb...@google.com <jb...@google.com> #4
al...@gmail.com <al...@gmail.com> #5
Re
In the future, please always file regressions as new bugs with a sample project that reproduces your issue rather than commenting on issues already marked as fixed - that way we can properly track those fixes for the next release.
al...@gmail.com <al...@gmail.com> #6
I would like to ask if this would be addressed in a future fix? I am planning to do a workaround that involves removing all nav args that use Serializable/Parcelable. It will be a big rework of our codebase, so I'd like to understand if there is any merit to this issue and if there is any appetite to fix this. I'd like to report the status of this issue to my higher-ups as soon as possible. Thanks
il...@google.com <il...@google.com> #7
We'll be addressing this in a Navigation 2.5.1 bug fix release.
al...@gmail.com <al...@gmail.com> #8
Thank you very much!
mi...@gmail.com <mi...@gmail.com> #9
mi...@gmail.com <mi...@gmail.com> #11
ap...@google.com <ap...@google.com> #12
Branch: androidx-main
commit 0027220b3ef51bf9c69ac0287c3699e0b87f6422
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jul 15 14:38:08 2022
Add deprecation suppressions to generated fromBundle
The getParcelableArray() and get() functions on Bundle have been
deprecated in SDK 33. This causes warning in the generated Safe Args
classes that use the fromBundle function with custom types.
We need to continue to use the old functions since we need to support
older platform versions so we should suppress the warnings on these
calls.
RelNote: "Navigation Safe Args will no longer cause deprecation warnings
in generated classes when using custom types."
Test: ./gradlew :navigation:navigation-safe-args-generator:test
--rerun-tasks
Bug: 237725966
Change-Id: Id86edf231b90176b5a0f03239bff628171a0284c
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/MainFragmentArgs.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
jb...@google.com <jb...@google.com> #13
This has been fixed internally and will be released in the Navigation 2.5.1
and 2.6.0-alpha01
versions.
na...@google.com <na...@google.com> #14
This bug was linked in a change in the following release(s):
androidx.navigation:navigation-safe-args-generator:2.6.0-alpha01
Description
Component used: Navigation
Version used: 2.4.2
Target SDK and Compile SDK version: 33
I would like to report that when building our app that targets API 33, the generated code for destination arguments in Navigation graphs use deprecated usages of Bundle (ie.
Bundle.get(String key)
,Bundle.getParcelableArray(String key)
Here is an example of how the generated code looks like (I modified arg names):
and another: