Fixed
Status Update
Comments
al...@gmail.com <al...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
al...@gmail.com <al...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
jb...@google.com <jb...@google.com> #4
Opening diff shortly
al...@gmail.com <al...@gmail.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
al...@gmail.com <al...@gmail.com> #6
I would like to ask if this would be addressed in a future fix? I am planning to do a workaround that involves removing all nav args that use Serializable/Parcelable. It will be a big rework of our codebase, so I'd like to understand if there is any merit to this issue and if there is any appetite to fix this. I'd like to report the status of this issue to my higher-ups as soon as possible. Thanks
il...@google.com <il...@google.com> #7
We'll be addressing this in a Navigation 2.5.1 bug fix release.
al...@gmail.com <al...@gmail.com> #8
Thank you very much!
mi...@gmail.com <mi...@gmail.com> #9
Is this difficult to also backport the change to earlier releases? Upgrading to 2.5.1 might need to also upgrade other dependencies.
mi...@gmail.com <mi...@gmail.com> #11
Is there an estimated release date for 2.5.1? Thank you!
ap...@google.com <ap...@google.com> #12
Project: platform/frameworks/support
Branch: androidx-main
commit 0027220b3ef51bf9c69ac0287c3699e0b87f6422
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jul 15 14:38:08 2022
Add deprecation suppressions to generated fromBundle
The getParcelableArray() and get() functions on Bundle have been
deprecated in SDK 33. This causes warning in the generated Safe Args
classes that use the fromBundle function with custom types.
We need to continue to use the old functions since we need to support
older platform versions so we should suppress the warnings on these
calls.
RelNote: "Navigation Safe Args will no longer cause deprecation warnings
in generated classes when using custom types."
Test: ./gradlew :navigation:navigation-safe-args-generator:test
--rerun-tasks
Bug: 237725966
Change-Id: Id86edf231b90176b5a0f03239bff628171a0284c
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/MainFragmentArgs.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
https://android-review.googlesource.com/2154200
Branch: androidx-main
commit 0027220b3ef51bf9c69ac0287c3699e0b87f6422
Author: Jeremy Woods <jbwoods@google.com>
Date: Fri Jul 15 14:38:08 2022
Add deprecation suppressions to generated fromBundle
The getParcelableArray() and get() functions on Bundle have been
deprecated in SDK 33. This causes warning in the generated Safe Args
classes that use the fromBundle function with custom types.
We need to continue to use the old functions since we need to support
older platform versions so we should suppress the warnings on these
calls.
RelNote: "Navigation Safe Args will no longer cause deprecation warnings
in generated classes when using custom types."
Test: ./gradlew :navigation:navigation-safe-args-generator:test
--rerun-tasks
Bug: 237725966
Change-Id: Id86edf231b90176b5a0f03239bff628171a0284c
M navigation/navigation-safe-args-generator/src/test/test-data/expected/java_nav_writer_test/MainFragmentArgs.java
M navigation/navigation-safe-args-generator/src/test/test-data/expected/kotlin_nav_writer_test/MainFragmentArgs.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/java/JavaNavWriter.kt
M navigation/navigation-safe-args-generator/src/main/kotlin/androidx/navigation/safe/args/generator/kotlin/KotlinNavWriter.kt
jb...@google.com <jb...@google.com> #13
This has been fixed internally and will be released in the Navigation 2.5.1
and 2.6.0-alpha01
versions.
na...@google.com <na...@google.com> #14
This bug was linked in a change in the following release(s):
androidx.navigation:navigation-safe-args-generator:2.6.0-alpha01
Description
Component used: Navigation
Version used: 2.4.2
Target SDK and Compile SDK version: 33
I would like to report that when building our app that targets API 33, the generated code for destination arguments in Navigation graphs use deprecated usages of Bundle (ie.
Bundle.get(String key)
,Bundle.getParcelableArray(String key)
Here is an example of how the generated code looks like (I modified arg names):
and another: