When inherit class which is based on ViewModelProvider.AndroidViewModelFactory , "fun create(modelClass, extra)" must be overriden instead of "fun create(modelClass)" [238011621]

Fixed

Bug

Status Update

No update yet.

Description

ga...@linecorp.com

created issue #1

Jul 5, 2022 06:04AM

Component used: androidx.lifecycle.viewmodel

Version used: 2.5.0

Description:

Since lifecycle 2.5.0, ViewModelProvider creates ViewModel instance with ViewModelFactory.create(modelClass, extra) method if this method is implemented.

https://github.com/androidx/androidx/blob/589d3bc8/lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelProvider.kt#L186-L190

In ViewModelProvider.AndroidViewModelFactory class case, it provides both of create(modelClass, extra) and create(modelClass), but it will always use create(modelClass, extra) only.

Need documentation that create(modelClass) method is not used anymore if class is inherited from ViewModelProvider.AndroidViewModelFactory,
Or deprecate ViewModelProvider.AndroidViewModelFactory.create(modelClass)
Or please give warning (by lint checker) when developer override create(modelClass) method only instead of create(modelClass, extra) for ViewModelProvider.AndroidViewModelFactory class.

Comments

il...@google.com <il...@google.com> #2Jul 13, 2022 11:37PM

Assigned to jb...@google.com.

To use Lifecycle 2.8.0-alpha03, ensure you are using at least Compose UI 1.7.0-alpha05.

The issue is happening because, starting from Lifecycle 2.8.0-alpha03 and Compose UI 1.7.0-alpha05, LocalLifecycleOwner has been moved from androidx.compose.ui to lifecycle-runtime-compose, as outlined in their respective release notes. For compatibility reasons, you must update both dependencies.

For context, note these changes were made to enable the utilization of its Compose-based helper APIs beyond Compose UI (such as in Molecule). Further information can be found at b/328263448.

If the issue persists even after updating your Compose UI, please let us know.

Edit: please see https://issuetracker.google.com/336842920#comment8 for a workaround.

ap...@google.com <ap...@google.com> #3Jul 18, 2022 09:34PM

Thanks for your answer.
If this change has made both libraries version dependent, it seems that guide them to the release note so that users will not experience difficulties :)

jb...@google.com <jb...@google.com> #4Jul 18, 2022 09:40PM

Marked as fixed.

lifecycle 2.8.0 is now stable but compose UI 1.7.0 is still in beta.

na...@google.com <na...@google.com> #5Sep 12, 2022 05:52PM

Same problem here. Lifecycle 2.8.0 is now stable but Compose UI 1.7.0 is still beta. Of course our Dependabot didn't know about this relationship between dependencies 😬

Issue 238011621

Description

Issue summary

Comments

il...@google.com <il...@google.com> #2Jul 13, 2022 11:37PM

ap...@google.com <ap...@google.com> #3Jul 18, 2022 09:34PM

jb...@google.com <jb...@google.com> #4Jul 18, 2022 09:40PM

na...@google.com <na...@google.com> #5Sep 12, 2022 05:52PM

Add comment

Issue metadata