Fixed
Status Update
Comments
jn...@google.com <jn...@google.com>
jn...@google.com <jn...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
jn...@google.com <jn...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
jn...@google.com <jn...@google.com> #4
deleted
jn...@google.com <jn...@google.com>
di...@gmail.com <di...@gmail.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-main
commit ff6fae95f64c40e7d75bfc0180d940dff28556fa
Author: John Nichol <jnichol@google.com>
Date: Wed Jul 13 14:19:51 2022
Explicitly set the disabledBackgroundColor for Chip childChipColors
Bug: 238057342
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
RelNote: "Fixed a bug in the ChipDefaults.childChipColor() to ensure that the disabled background color is full transparent."
Change-Id: I2b3c3ffdf046b9202e56411160ad41a51a1c6fb7
M wear/compose/compose-material/src/androidAndroidTest/kotlin/androidx/wear/compose/material/ChipTest.kt
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Chip.kt
https://android-review.googlesource.com/2152756
Branch: androidx-main
commit ff6fae95f64c40e7d75bfc0180d940dff28556fa
Author: John Nichol <jnichol@google.com>
Date: Wed Jul 13 14:19:51 2022
Explicitly set the disabledBackgroundColor for Chip childChipColors
Bug: 238057342
Test: ./gradlew :wear:compose:compose-material:connectedCheck --info --daemon
RelNote: "Fixed a bug in the ChipDefaults.childChipColor() to ensure that the disabled background color is full transparent."
Change-Id: I2b3c3ffdf046b9202e56411160ad41a51a1c6fb7
M wear/compose/compose-material/src/androidAndroidTest/kotlin/androidx/wear/compose/material/ChipTest.kt
M wear/compose/compose-material/src/commonMain/kotlin/androidx/wear/compose/material/Chip.kt
Description
Component used: androidx.wear.compose:compose-material Version used: 1.0.0-rc02 Devices/Android versions reproduced on: All
Chip.kt childChipColors intends for the background to be transparent, but the disabled state overrides the alpha value, causing the background to appear a dark black instead of transparent.
Chip.kt childChipColors contains this code:
It should also override disabledBackgroundColor, also setting it to Color.Transparent. The default is
disabledBackgroundColor: Color = backgroundColor.copy(alpha = ContentAlpha.disabled),
which results in a dark black background for the chip.