gcloud app deploy fails for go 1.16 apps using go:embed in GOPATH mode [238368991]

Assigned

Bug

Status Update

No update yet.

Description

ry...@derivita.com

created issue #1

Jul 8, 2022 04:34PM

Problem you have encountered:

When you use go:embed with a go 1.16 app engine app and try to deploy it using GOPATH mode, the go-app-stager fails. It seems to not recognize that "embed" is part of the standard library as of go 1.16:

ERROR: (gcloud.app.deploy) Staging command [/usr/lib/google-cloud-sdk/platform/google_appengine/go-app-stager /home/ryan/embed/gopath/src/example.com/embedder/app.yaml /home/ryan/embed/gopath/src/example.com/embedder /tmp/tmpj5304m6z/tmpsupd859i] failed with return code [1].

------------------------------------ STDOUT ------------------------------------
------------------------------------ STDERR ------------------------------------
2022/07/08 16:06:17 staging for go1.16
2022/07/08 16:06:17 GO111MODULE=auto, but no go.mod found, so building with dependencies from GOPATH
main-package: example.com/embedder
2022/07/08 16:06:17 Staging app (GOPATH mode): failed analyzing /home/ryan/embed/gopath/src/example.com/embedder: cannot find package "embed" in any of:
        ($GOROOT not set)
        /home/ryan/embed/gopath/src/embed (from $GOPATH)
GOPATH: /home/ryan/embed/gopath
--------------------------------------------------------------------------------

What you expected to happen:

The app would deploy without errors. The same code works if you add a go.mod file.

Steps to reproduce:

Sample code is at https://github.com/ribrdb/silver-engine This version fails: GOPATH=$PWD/gopath gcloud app deploy gopath/src/example.com/embedder But the go.mod version works: gcloud app deploy mod

Other information (workarounds you have tried, documentation consulted, etc):

Comments

ry...@derivita.com <ry...@derivita.com> #2Jul 8, 2022 04:37PM

[Comment deleted]

ma...@postmastery.net <ma...@postmastery.net> #3Dec 5, 2022 11:51AM

Would you be able to provide an example app which produces an error for which gcloud doesn't report, but appcfg.py does?

va...@google.com <va...@google.com> Jun 23, 2023 06:32AM

Assigned to su...@google.com.

su...@google.com <su...@google.com> #4Jun 27, 2023 07:09AM

In this case it is not app specific, The 400 error is due to quota of the application versions being over the limit which is 10 (but for this specific project it has been increased to 60). So any project with more than 10 versions will experience this.

ry...@derivita.com <ry...@derivita.com> #5Jun 27, 2023 02:00PM

[Comment deleted]

su...@google.com <su...@google.com> #6Jul 4, 2023 11:46AM

Status: Won't Fix (Infeasible)

I have forwarded this request/report to the engineering team. We will update this issue with any progress updates and a resolution.

ry...@derivita.com <ry...@derivita.com> #7Jul 4, 2023 02:05PM

I'm sorry that is not a fix. I specified in the title this is an issue using GOPATH, which the app engine documentation says should work: "you can continue to use the older GOPATH mode if you aren't ready to migrate to Go modules."

When you create a go.mod file it completely changes how dependencies are loaded. I mentioned above that it works if you switch to modules, but that is a non-trivial change and the documentation says it is not required.

ba...@google.com <ba...@google.com> Feb 15, 2024 08:53AM

Status: Assigned (reopened)

su...@google.com <su...@google.com> #8Feb 15, 2024 12:04PM

Reassigned to gc...@google.com.

Hello,

Thank you for reporting this issue.

I investigated the issue again. The workaround suggested in the #comment6 is related to the App engine stopping use of GOPATH mode. The error has been found in GAE while choosing the GOPATH mode. I apologize for the inconvenience caused due to closing this PIT.

This issue has been reported to the Engineering team. The team is currently working on the issue. While we cannot provide an estimated time for resolving the issue, please be assured that your input is highly valued. Your feedback enables us to enhance our products and services.

We appreciate your continued trust and support in improving our Google Cloud Platform products. In case you want to report a new issue, Please do not hesitate to create a new issue on the Issue Tracker providing a detailed description of your issue.

Once again, we sincerely appreciate your valuable feedback; Thank you for your understanding and collaboration.