Fixed
Status Update
Comments
il...@google.com <il...@google.com>
il...@google.com <il...@google.com>
ap...@google.com <ap...@google.com> #2
since these are in public API (:/) we need to do this in 1.2
cl...@google.com <cl...@google.com> #3
since it is already marked as deprecated, we can probably do it by now.
st...@gmail.com <st...@gmail.com> #4
Opening diff shortly
na...@google.com <na...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
Description
Component used: Navigation Version used: 2.4 Devices/Android versions reproduced on: all
AppCompatActivity::setupActionBarWithNavController
can be called to automatically update app bar content when navigation destination changes. In particular,setupActionBarWithNavController
promises to automatically hide the Up arrow for "top-level" destinations and show the Up arrow for all other destinations. To achieve this,setupActionBarWithNavController
needs to infer or be told which destinations are "top-level".When using a
BottomNavigationView
, I wantedI tried calling
setupActionBarWithNavController
and passing a customAppBarConfiguration
constructed using theMenu
instance from theBottomNavigationView
:Unfortunately, when passed a
Menu
whose entries correspond to navigation graph IDs,AppBarConfiguration::Builder
sets the graph IDs as top-level destination IDs, rather than the setting the graph start destination IDs as top-level destination IDs. The result is that theAbstractAppBarOnDestinationChangedListener
applied bysetupActionBarWithNavController
mistakenly classifies every destination as top-level and no screens have an Up arrow.This can be worked around by explicitly passing the IDs of the start destinations of each tab's graph when constructing the
AppBarConfiguration
builder:However, the behavior of
AppBarConfiguration.Builder(Menu)
remains surprising and it would be good to investigate whether that constructor could be made to behave as I anticipated!Android Study Group Slack thread:https://androidstudygroup.slack.com/archives/CAZCL8AVB/p1656470310000929?thread_ts=1655997032.467509&cid=CAZCL8AVB