Support for "isLightTheme" attribute [238522114]

Fixed

Bug

Status Update

No update yet.

Description

0x...@gmail.com

created issue #1

Jul 11, 2022 08:59AM

Component used: core-splashscreen Version used: 1.0.0-rc01 Devices/Android versions reproduced on: Pixel 2

The "isLightTheme" attribute is not supported in these cases:

<item name="android:windowLightStatusBar">?attr/isLightTheme</item>

<item name="android:windowLightNavigationBar">?attr/isLightTheme</item>

For now, the solution is to create themes.xml(night) and override these attributes.

Comments

ca...@google.com <ca...@google.com> Jul 11, 2022 12:06PM

Reassigned to wi...@google.com.

wi...@google.com <wi...@google.com> Apr 14, 2023 02:41AM

Reassigned to an...@google.com.

rg...@google.com <rg...@google.com> Aug 9, 2024 08:29AM

Reassigned to ch...@google.com.

ap...@google.com <ap...@google.com> #2Aug 12, 2024 07:52AM

Project: platform/frameworks/support
Branch: androidx-main

commit 3222e3bab1de8f3bfdcfef424cb59ef9627e366f
Author: chunmu <chunmu@google.com>
Date: Thu Aug 08 16:27:45 2024

Support isLightTheme attribute in themes of SplashScreen

Make the themes used by the SplashScreen library to support `isLightTheme`
attribute

Bug: 238522114
Relnote: Add isLightTheme attribute to themes of SplashScreen
Test: Manually tested this attribute in the sample app over a range of
API levels
Change-Id: I010005266ec4b1dae815937ab0fcf28bb7d05267
Signed-off-by: Chun-Mu Weng <chunmu@google.com>

M core/core-splashscreen/src/main/res/values-night/styles.xml
M core/core-splashscreen/src/main/res/values-v29/styles.xml
M core/core-splashscreen/src/main/res/values-v30/styles.xml
M core/core-splashscreen/src/main/res/values-v31/styles.xml
M core/core-splashscreen/src/main/res/values/attrs.xml
M core/core-splashscreen/src/main/res/values/styles.xml

https://android-review.googlesource.com/3213178

ch...@google.com <ch...@google.com> Sep 3, 2024 07:12AM

Marked as fixed.

pr...@google.com <pr...@google.com> #3Sep 5, 2024 08:09PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.core:core-splashscreen:1.2.0-alpha02

de...@gmail.com <de...@gmail.com> #4Dec 17, 2024 09:54PM

Notificaciones

Hola, estoy.txt

IssueTracker