Need a way to place with respect to the hinge on foldable displays [238632578]

Fixed

Feature Request

Status Update

No update yet.

Description

mo...@google.com

created issue #1

Jul 11, 2022 04:04PM

On foldable displays, we sometimes want to measure and place content in relation to the hinge position.

We can solve this by providing LayoutCoordinates inside the placement lambda. It won't be available during alignment lines queries, so it must be nullable, but it should be available during regular placement. The use should be something like this:

Layout { measurables, constraints ->

layout(constraints.maxWidth, constraints.maxHeight) {
   if (coordinates != null) {
      val hingeX = findHingeOffset(coordinates)
      val leftOfHinge = measurables[0].measure(Constraints.fixedWidth(hingeX))
      leftOfHinge.place(0, 0)

      val rightOfHinge = measurables[1].measure(Constraints.fixedWidth(coordinates.width - hingeX)
      rightOfHinge.place(hingeX, 0)
   }
}

Comments

ap...@google.com <ap...@google.com> #2Jul 21, 2022 08:23PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 498d903b3502eabb907e98ad0273f3e393e6e194
Author: George Mount <mount@google.com>
Date: Mon Jul 11 14:58:59 2022

Add LayoutCoordinates.transformFrom

Fixes: 238632578

Relnote: "Added LayoutCoordinates.transformFrom to
get the Matrix transformation from one LayoutCoordinates
to another."

Test: new tests. manual testing
Change-Id: Ic5ab114e2fb6453c062e1450982081e18d190f9d

M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/OwnedLayer.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/RenderNodeLayer.android.kt
M compose/ui/ui/api/current.txt
M compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/SkiaLayer.skiko.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/LookaheadLayoutTest.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
M compose/ui/ui/api/restricted_current.txt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/LayoutCoordinates.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/ViewLayer.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/LookaheadLayoutCoordinates.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/HitPathTrackerTest.kt
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2151737

ap...@google.com <ap...@google.com> #3Jul 23, 2022 03:55AM

Project: platform/frameworks/support
Branch: androidx-main

commit 54c6e5dba55115580b40d71bcc5994cfd37e5471
Author: George Mount <mount@google.com>
Date: Thu Jun 30 10:57:34 2022

Add LayoutCoordinates to PlacementScope

Fixes: 238632578

Relnote: "Added experimental API to get the LayoutCoordinates
in the PlacementScope. This lets developers know where the
current layout is to place children relative to its position."

Test: new tests. Manual testing with new sample.
Change-Id: I5482bf4604e700d9f5a753142fe0db3f306939fd

M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/InnerPlaceable.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/MeasureAndLayoutDelegate.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/ModifiedLayoutNode.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeLayoutDelegate.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeDrawScope.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/MeasureScope.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/layout/Placeable.kt
M compose/ui/ui/src/test/kotlin/androidx/compose/ui/node/LayoutNodeTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/PlacementLayoutCoordinatesTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LookaheadDelegate.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNodeWrapper.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/IntrinsicsPolicy.kt
A compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/PlacementScopeCoordinatesSample.kt
M compose/ui/ui/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2150333

Issue 238632578

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jul 21, 2022 08:23PM

ap...@google.com <ap...@google.com> #3Jul 23, 2022 03:55AM

Add comment

Issue metadata