Need a way to place with respect to the hinge on foldable displays [238632578]

Fixed

Feature Request

Status Update

No update yet.

Description

mo...@google.com

created issue #1

Jul 11, 2022 04:04PM

On foldable displays, we sometimes want to measure and place content in relation to the hinge position.

We can solve this by providing LayoutCoordinates inside the placement lambda. It won't be available during alignment lines queries, so it must be nullable, but it should be available during regular placement. The use should be something like this:

Layout { measurables, constraints ->

layout(constraints.maxWidth, constraints.maxHeight) {
   if (coordinates != null) {
      val hingeX = findHingeOffset(coordinates)
      val leftOfHinge = measurables[0].measure(Constraints.fixedWidth(hingeX))
      leftOfHinge.place(0, 0)

      val rightOfHinge = measurables[1].measure(Constraints.fixedWidth(coordinates.width - hingeX)
      rightOfHinge.place(hingeX, 0)
   }
}

Comments

ap...@google.com <ap...@google.com> #2Jul 21, 2022 08:23PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

ap...@google.com <ap...@google.com> #3Jul 23, 2022 03:55AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

Issue 238632578

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jul 21, 2022 08:23PM

ap...@google.com <ap...@google.com> #3Jul 23, 2022 03:55AM

Add comment

Issue metadata