Navigation with Fragment should use popWithTransition() [238686802]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Jul 12, 2022 12:04AM

Navigation 2.4 introduced new Navigator APIs that were equipped to handle transitions, ensuring that NavBackStackEntries would always be in the proper state. (i.e. STARTED until the incoming transition completes then moving RESUMED or CREATED until the outgoing transition completes and then moving to DESTROYED).

Now that these APIs are available, they should also be implemented in Navigation with Fragments. This would ensure that the state of Fragment also follows the same conventions of NavBackStackEntry and provides properly Lifecycle updates while handling animations, animators, and transitions.

Comments

jb...@google.com <jb...@google.com> #2Jul 12, 2022 12:05AM

since these are in public API (:/) we need to do this in 1.2

ap...@google.com <ap...@google.com> #3Feb 2, 2023 02:44AM

since it is already marked as deprecated, we can probably do it by now.

ap...@google.com <ap...@google.com> #4Feb 2, 2023 02:44AM

Opening diff shortly

ap...@google.com <ap...@google.com> #5Feb 2, 2023 02:44AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

jb...@google.com <jb...@google.com> #6Feb 2, 2023 03:04AM

Marked as fixed.

This has been fixed internally and will be in the Navigation 2.6.0-alpha05 and Fragment 1.6.0-alpha05 releases.

pr...@google.com <pr...@google.com> #7Feb 8, 2023 06:21PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.fragment:fragment:1.6.0-alpha05
androidx.navigation:navigation-common:2.6.0-alpha05
androidx.navigation:navigation-fragment:2.6.0-alpha05
androidx.navigation:navigation-runtime:2.6.0-alpha05
androidx.navigation:navigation-testing:2.6.0-alpha05

Issue 238686802