Update targetSdk to 33 [238790278]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jul 12, 2022 08:30PM

We need targetSdk to be 33 before we move forward with upstreaming, otherwise we are releasing potentially broken code in betas.

Comments

al...@google.com <al...@google.com> #2Jul 12, 2022 08:35PM

Accepted by al...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 64f11e5722d8a574ccb72bfb042fa89f51129c68
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Wed Aug 28 21:20:11 2019

API lint check for the MinMaxConstant is enabled for androidx

Existing issues are suppressed with the @SuppressLint("MinMaxConstant")
annotation and the MinMaxConstant is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I29b78a0a024984113ca37145f1cb2a31a82c7b25

M browser/src/main/java/androidx/browser/browseractions/BrowserActionsIntent.java
M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M dynamic-animation/src/main/java/androidx/dynamicanimation/animation/DynamicAnimation.java
M enterprise/feedback/src/main/java/androidx/enterprise/feedback/KeyedAppState.java
M paging/common/api/api_lint.ignore
M work/workmanager/src/main/java/androidx/work/Configuration.java
M work/workmanager/src/main/java/androidx/work/Data.java
M work/workmanager/src/main/java/androidx/work/PeriodicWorkRequest.java
M work/workmanager/src/main/java/androidx/work/WorkRequest.java

https://android-review.googlesource.com/1114511

https://goto.google.com/android-sha1/64f11e5722d8a574ccb72bfb042fa89f51129c68

al...@google.com <al...@google.com> #3Jul 12, 2022 08:56PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 536a1ff3c3c7623ef60ef89b45266afd63ca748f
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Tue Sep 17 23:22:14 2019

API lint check for the SetterReturnsThis is enabled for androidx

Existing issues are suppressed with updated baseline and the
SetterReturnsThis is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: Ieea569421478ab7f7135aedbc16448b2d03741fe

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt
M navigation/navigation-common-ktx/api/api_lint.ignore
M paging/common/api/api_lint.ignore
M paging/runtime/api/api_lint.ignore
A paging/rxjava2/api/api_lint.ignore
M recyclerview/recyclerview/api/api_lint.ignore
M room/runtime/api/api_lint.ignore
M work/workmanager/api/api_lint.ignore

https://android-review.googlesource.com/1123398

https://goto.google.com/android-sha1/536a1ff3c3c7623ef60ef89b45266afd63ca748f

al...@google.com <al...@google.com> #4Jul 12, 2022 09:00PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8aecbea988804f4f702812f6e7f50bc60359eed1
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 17:50:47 2019

API lint check for the PackageLayering is enabled for androidx

PackageLayering is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I9a6c33d6686fa63f98cd150e5f8d97a57ea14472

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126765

https://goto.google.com/android-sha1/8aecbea988804f4f702812f6e7f50bc60359eed1

al...@google.com <al...@google.com> Jul 13, 2022 07:04PM

Marked as fixed.

na...@google.com <na...@google.com> #5Sep 12, 2022 05:51PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 7426c6889ba80df99b2589454d0f604e0efd7b78
Author: Sergey <zakharovsergey1000@gmail.com>
Date: Sun Sep 22 19:39:30 2019

API lint check for the OverlappingConstants is enabled for androidx

OverlappingConstants is turned into an error in androidx configuration

Bug: 138602561

Test: ./gradlew checkApi
Change-Id: I312b39963b0b64e06a3bd5933156dc88bff76a1c

M buildSrc/src/main/kotlin/androidx/build/metalava/MetalavaRunner.kt

https://android-review.googlesource.com/1126766

https://goto.google.com/android-sha1/7426c6889ba80df99b2589454d0f604e0efd7b78

Issue 238790278