Update targetSdk to 33 [238790278]

Fixed

Bug

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jul 12, 2022 08:30PM

We need targetSdk to be 33 before we move forward with upstreaming, otherwise we are releasing potentially broken code in betas.

Comments

al...@google.com <al...@google.com> #2Jul 12, 2022 08:35PM

Accepted by al...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit ed4cbc0c50bb906d78cc1617be5ad7fcb14c56f5
Author: Oscar Adame Vázquez <oscarad@google.com>
Date: Wed Jan 17 13:54:01 2024

Add Alignment parameter to animateContentSize

Note that it actually adds a new function altogether to fit existing
use cases where the trailing lambda causes the API to be inflexible
(can't add parameters before or after the lambda).

Relnote: "Added alignment parameter to` Modifier.animateContentSize()`."

Bug: 269803907
Test: AnimationModifierTest.testAlignmentInAnimateContentSize
Change-Id: I5623af336f137bb4464cbf7993942452e86bcd88

M compose/animation/animation/api/current.txt
M compose/animation/animation/api/restricted_current.txt
M compose/animation/animation/src/androidInstrumentedTest/kotlin/androidx/compose/animation/AnimationModifierTest.kt
M compose/animation/animation/src/commonMain/kotlin/androidx/compose/animation/AnimationModifier.kt

https://android-review.googlesource.com/2915193

al...@google.com <al...@google.com> #3Jul 12, 2022 08:56PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.animation:animation:1.7.0-alpha03
androidx.compose.animation:animation-android:1.7.0-alpha03
androidx.compose.animation:animation-desktop:1.7.0-alpha03

al...@google.com <al...@google.com> #4Jul 12, 2022 09:00PM

The big one is that every usage of notify in a library needs to be wrapped with either a permission check or annotated with @RequiresPermission. My current plan is to add the annotation. Hopefully these usages are close enough to public API surfaces that it works out cleanly.

The usages in integration tests will probably cause failures, but I'm not going to fix those myself. The SoonBlockedPrivateApi will need to be fixed by the benchmark owner. Again, not gonna fix that.

al...@google.com <al...@google.com> Jul 13, 2022 07:04PM

Marked as fixed.

na...@google.com <na...@google.com> #5Sep 12, 2022 05:51PM

This bug was linked in a change in the following release(s):

androidx.car.app:app-testing:1.3.0-beta01

Issue 238790278