Always dismiss the DialogFragment when the Dialog is dismissed [238928865]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue on behalf of vi...@google.com #1

Jul 13, 2022 09:55PM

Whenever overriding DialogFragment's onDismiss() or onCancel() functions, developers should also call super to ensure that they still execute the functionality of the DialogFragment in their custom component.

Comments

jb...@google.com <jb...@google.com> #2Jul 13, 2022 10:05PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

il...@google.com <il...@google.com> Aug 25, 2022 11:18PM

Assigned to sa...@google.com.

ap...@google.com <ap...@google.com> #3Aug 31, 2022 11:13PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4b8e7bb8638fcf2f22f74ff3ef94811d90c3c3e3
Author: Sanura N'Jaka <sanura@google.com>
Date: Tue Aug 30 19:52:18 2022

Have DialogFragment always dismiss

Using the onDismissListener to ensure that
DialogFragment always dismisses the dialog
regardless of whether super.onDismiss()
is called when overriden.

RelNote: "`DialogFragment` will now always
dismiss the dialog whenever `dismiss()`
(or `dismissNow()`) is called, regardless
of whether `super.onDismiss()` is called
when overriden."
Test: DialogFragmentTest.testDismissDialogFragmentNoSuperCall
Bug: 238928865

Change-Id: Ifc93bcf45a8fbae382c98b3c489b7ed64f5c4d8e

M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
M fragment/fragment/src/androidTest/java/androidx/fragment/app/DialogFragmentTest.kt

https://android-review.googlesource.com/2199784

il...@google.com <il...@google.com> #4Aug 31, 2022 11:26PM

Marked as fixed.

This has been fixed internally (it is no longer necessary to call super.onDismiss(Dialog) at all - that work now happens immediately before the call to onDismiss()) and will be available in Fragment 1.6.0-alpha03.

jb...@google.com <jb...@google.com> Sep 8, 2022 07:25PM

Status: New (reopened)

jb...@google.com <jb...@google.com> #5Sep 8, 2022 10:15PM

We ran into a situation where this changed behavior could cause some issues. So we will just be adding the @CallSuper annotation instead.

ap...@google.com <ap...@google.com> #6Sep 8, 2022 10:22PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3fbc5d7acb68e581f167460c11ee68474776981d
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Sep 08 12:18:34 2022

Add a @CallSuper to DialogFragment onDismiss

Inorder to ensure that classes extending DialogFragment get the proper
dismiss behavior, they should always call super in their onDismiss
overrides.

RelNote: "Classes extending `DialogFragment` will now be required to
call super in their `onDismiss()` overrides."
Test: this adds an annotation that is verified via lint & ./gradlew
checkApi
Bug: 238928865

Change-Id: I147983f443693b1cafbd996cbbacd726e2dd2130

M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/2211716

jb...@google.com <jb...@google.com> #7Sep 8, 2022 10:56PM

Marked as fixed, reassigned to jb...@google.com.

This has been fixed internally (again) and will be available in Fragment 1.6.0-alpha03.

na...@google.com <na...@google.com> #8Sep 21, 2022 05:51PM

Comment has been deleted.

Message last modified on Sep 21, 2022 05:53PM

na...@google.com <na...@google.com> #9Oct 5, 2022 05:15PM

This bug was linked in a change in the following release(s):

androidx.fragment:fragment:1.6.0-alpha03