Fixed
Status Update
No update yet.
Comments
jb...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
il...@google.com
ap...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
il...@google.com
This has been fixed internally (it is no longer necessary to call super.onDismiss(Dialog) at all - that work now happens immediately before the call to onDismiss()) and will be available in Fragment 1.6.0-alpha03.
jb...@google.com
jb...@google.com
We ran into a situation where this changed behavior could cause some issues. So we will just be adding the @CallSuper annotation instead.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3fbc5d7acb68e581f167460c11ee68474776981d
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Sep 08 12:18:34 2022
Add a @CallSuper to DialogFragment onDismiss
Inorder to ensure that classes extending DialogFragment get the proper
dismiss behavior, they should always call super in their onDismiss
overrides.
RelNote: "Classes extending `DialogFragment` will now be required to
call super in their `onDismiss()` overrides."
Test: this adds an annotation that is verified via lint & ./gradlew
checkApi
Bug: 238928865
Change-Id: I147983f443693b1cafbd996cbbacd726e2dd2130
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
https://android-review.googlesource.com/2211716
Branch: androidx-main
commit 3fbc5d7acb68e581f167460c11ee68474776981d
Author: Jeremy Woods <jbwoods@google.com>
Date: Thu Sep 08 12:18:34 2022
Add a @CallSuper to DialogFragment onDismiss
Inorder to ensure that classes extending DialogFragment get the proper
dismiss behavior, they should always call super in their onDismiss
overrides.
RelNote: "Classes extending `DialogFragment` will now be required to
call super in their `onDismiss()` overrides."
Test: this adds an annotation that is verified via lint & ./gradlew
checkApi
Bug: 238928865
Change-Id: I147983f443693b1cafbd996cbbacd726e2dd2130
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/api/current.txt
M fragment/fragment/api/public_plus_experimental_current.txt
jb...@google.com
This has been fixed internally (again) and will be available in Fragment 1.6.0-alpha03.
na...@google.com
Comment has been deleted.
na...@google.com
This bug was linked in a change in the following release(s):
androidx.fragment:fragment:1.6.0-alpha03
Description
Whenever overriding
DialogFragment'sonDismiss()oronCancel()functions, developers should also call super to ensure that they still execute the functionality of theDialogFragmentin their custom component.