Lint: PartialResults merging works incorrectly [239337003]

Fixed

Bug

Status Update

No update yet.

Description

li...@gmail.com

created issue #1

Jul 18, 2022 04:46PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

Download project from the attach;
Run ./gradlew :app:lintDebug and observe 2 issues;
Run ./gradlew :lint-checks:test and observe tests failing.

It looks like PartialResult#map doesn't follow the contract in unit tests. It claims to return LintMap for the project in context, but under the certain condition it seems to be violated.

The conditions require multimodule setup. A library module must put smth into its LintMap. Then, when the app module accesses its own LintMap for the first time it get a map prefilled with the data from the library module, instead of the fresh one.

To demonstrate the issue I created the following setup:

An :app module and a :library module;
:app module contains app_color color resource, while :library module contains :library_color;
I created a simple detector, which works only in partial analysis mode and does a simple thing: detects the color resource declaration within the module, puts into the partial results and then reports all colors found per module in checkPartialResults method;
There's a unit test, which mimics the same setup.

If you run lint checks using the ./gradlew :app:lintDebug command, you'll observe Lint correctly reporting app_color found in :app and library_color found in :library. However, if you run the unit tests, you'll observe that Lint also reports a library_color found in the :app.

It looks like while scanning the :app module, the first access to partial results, causes LintCliClient to create new instance of results and fill it with results of the dependent module (see LintCliClient#getPartialResults method). For some reason this is happening only in tests.

The replacement of the getPartialResult.map() method call with getPartialResult.mapFor(context.project) method call successfully addresses the issue.

There's still a chance, that my test is wrong. In this case, would be great to know in which way.

Studio Build: Chipmunk | 2021.2.1 Version of Gradle Plugin: 7.2.1, 7.4.0-alpha08 Version of Gradle: 7.4.2 OS: Mac OS Monteray 12.4

LintBug2.zip

803 KB

Download

Comments

li...@gmail.com <li...@gmail.com> #2Jul 18, 2022 04:58PM

Here is the stacktrace:

java.lang.VerifyError: Verifier rejected class WN: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent) failed to verify: android.app.Notification$Style WN.h(android.app.Person, android.app.PendingIntent): [0x4]  can't resolve returned type 'Reference: android.app.Notification$Style' or 'Unresolved Reference: android.app.Notification$CallStyle' (declaration of 'WN' appears in base.apk!classes4.dex)
	at Tj.<init>(SourceFile:17)
	at kT1.<init>(SourceFile:23)
	at aL1.<init>(SourceFile:293)
	at bh4.get(SourceFile:1606)
	at cL1.a(SourceFile:29)
	at cL1.e(SourceFile:17)
	at s1i.getValue(Unknown Source:17)
	at dL1.a(SourceFile:11)
	at RQ1.b(Unknown Source:2)
	at EQ1.execute(SourceFile:15)
	at lU1.handleMessage(SourceFile:18)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at N52.dispatchMessage(SourceFile:7)
	at android.os.Looper.loop(Looper.java:237)
	at android.os.HandlerThread.run(HandlerThread.java:67)

Unfortunately, I can't share the dex2oat logs for this as I'm running into this problem on Android 11 emulator and I don't have a rooted Android 11 device on-hand.

ch...@google.com <ch...@google.com> Jul 20, 2022 01:09PM

Assigned to an...@google.com.

li...@gmail.com <li...@gmail.com> #3Jul 20, 2022 03:45PM

Thanks for the report. Can you share the APK failing and give suggestions to force the error such that I can see the entire logcat on device. The outline is looking correct so I believe the error is someplace else and logcat will show that.

je...@google.com <je...@google.com> Jul 26, 2022 01:20AM

Reassigned to sp...@google.com.

sp...@google.com <sp...@google.com> #4Jul 26, 2022 05:00PM

Reassigned to ra...@google.com.

I shared the APK and instructions to reproduce over email. Let me know if you have any trouble reproing the crash.

ra...@google.com <ra...@google.com> Aug 15, 2022 06:32PM

Reassigned to pa...@google.com.

pa...@google.com <pa...@google.com> Aug 30, 2022 11:11AM

Reassigned to pa...@google.com.

pa...@google.com <pa...@google.com> #5Aug 30, 2022 07:38PM

Thank you for the dump and information. Turns out that behavior of the verifier changed on Android 11 and 12 but was reverted again. I am working on a fix that should be easy to merge to the 4.0 branch.

Note that the verification error is actually also easy to create by manual outlining, but our pattern just emphasize it.

li...@gmail.com <li...@gmail.com> #6Sep 9, 2022 12:14PM

Project: r8
Branch: main

commit b7b22190797c9b74218fb1d2fdfb497a9be9fb3b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 13:03:38 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

Change-Id: I2479d669217d90f057fa248fcea0f0f27faf91a6

M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
M src/main/java/com/android/tools/r8/ir/code/Return.java
M src/main/java/com/android/tools/r8/ir/conversion/IRConverter.java
M src/main/java/com/android/tools/r8/ir/desugar/apimodel/ApiInvokeOutlinerDesugaring.java
A src/main/java/com/android/tools/r8/ir/optimize/RemoveVerificationErrorForUnknownReturnedValues.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineHorizontalMergingTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineInstanceInitializerTest.java
M src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77221

pa...@google.com <pa...@google.com> #7Sep 23, 2022 11:46AM

Project: r8
Branch: main

commit 88dd6ed0006725301bcbe88942e474569c9aa1b1
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Mar 20 12:43:54 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

Change-Id: I5684a12bf42422bb96122422e063ffd0503fb5e5

M src/main/java/com/android/tools/r8/utils/AndroidApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelManualOutlineWithUnknownReturnTypeTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelOutlineWithUnknownReturnTypeTest.java

https://r8-review.googlesource.com/77180

pa...@google.com <pa...@google.com> #8Oct 25, 2022 09:34AM

Marked as fixed.

thanks for the fix. if this can be backported to 4.0 that would be great

li...@gmail.com <li...@gmail.com> #9Nov 1, 2022 04:59PM

Project: r8
Branch: 8.0

commit e1cdcb66b3a225076a41b646a2684d150a594693
Author: Rico Wind <ricow@google.com>
Date: Tue Mar 21 18:58:29 2023

Version 8.0.39

Bug:

b/272725341

Change-Id: Iad8a15631027cf587871f6c8df12a8b4c601296c

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77428

sa...@google.com <sa...@google.com> #10Nov 2, 2022 05:32PM

Project: r8
Branch: 8.0

commit 7248df9f87378eda019093887585afba9631a669
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:20 2023

[ApiModel] Insert CheckCast for return values causing verification error

Bug:

b/272725341

https://r8-review.googlesource.com/77425

sa...@google.com <sa...@google.com> #11Nov 3, 2022 01:42PM

Project: r8
Branch: 8.0

commit 4c0694de75503094bb84d6e28fd091453b172e2e
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Tue Mar 21 13:59:12 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77424

li...@gmail.com <li...@gmail.com> #12Jan 13, 2023 03:51PM

Project: r8
Branch: 4.0

commit 4fe0ece4d3da01068bf0b63cd7a5f37d47fa6244
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:30 2023

[ApiModel] Add tests for introducing verification issues when outlining

Bug:

b/272725341

https://r8-review.googlesource.com/77496

Message last modified on Jan 13, 2023 03:56PM

pa...@google.com <pa...@google.com> Jan 13, 2023 03:54PM

Status: Assigned (reopened)

pa...@google.com <pa...@google.com> #13Jan 18, 2023 05:45PM

Marked as fixed.

Project: r8
Branch: 4.0

commit 1e7c88c78ac0636eae649e132b862306ea416d48
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Mar 22 16:30:43 2023

Version 4.0.58

Bug:

b/272725341

Change-Id: If899ee42bdf757985546807d785639e98b3360e6

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/77494

li...@gmail.com <li...@gmail.com> #14May 9, 2023 12:04PM

Comment has been deleted.

Message last modified on May 9, 2023 12:06PM

li...@gmail.com <li...@gmail.com> #15May 9, 2023 12:06PM

I've backported the fix to version 4.0.58. Could you take that version for a spin to see if that solves the issues?

Issue 239337003

Description

Issue summary

Comments

li...@gmail.com <li...@gmail.com> #2Jul 18, 2022 04:58PM

ch...@google.com <ch...@google.com> Jul 20, 2022 01:09PM

li...@gmail.com <li...@gmail.com> #3Jul 20, 2022 03:45PM

je...@google.com <je...@google.com> Jul 26, 2022 01:20AM

sp...@google.com <sp...@google.com> #4Jul 26, 2022 05:00PM

ra...@google.com <ra...@google.com> Aug 15, 2022 06:32PM

pa...@google.com <pa...@google.com> Aug 30, 2022 11:11AM

pa...@google.com <pa...@google.com> #5Aug 30, 2022 07:38PM

li...@gmail.com <li...@gmail.com> #6Sep 9, 2022 12:14PM

pa...@google.com <pa...@google.com> #7Sep 23, 2022 11:46AM

pa...@google.com <pa...@google.com> #8Oct 25, 2022 09:34AM

li...@gmail.com <li...@gmail.com> #9Nov 1, 2022 04:59PM

sa...@google.com <sa...@google.com> #10Nov 2, 2022 05:32PM

sa...@google.com <sa...@google.com> #11Nov 3, 2022 01:42PM

li...@gmail.com <li...@gmail.com> #12Jan 13, 2023 03:51PM

pa...@google.com <pa...@google.com> Jan 13, 2023 03:54PM

pa...@google.com <pa...@google.com> #13Jan 18, 2023 05:45PM

li...@gmail.com <li...@gmail.com> #14May 9, 2023 12:04PM

li...@gmail.com <li...@gmail.com> #15May 9, 2023 12:06PM

Add comment

Issue metadata