IssueTracker

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:

1. Download project from the attach;
2. Run ./gradlew :app:lintDebug and observe 2 issues;
3. Run ./gradlew :lint-checks:test and observe tests failing.

It looks like PartialResult#map doesn't follow the contract in unit tests. It claims to return LintMap for the project in context, but under the certain condition it seems to be violated.

The conditions require multimodule setup. A library module must put smth into its LintMap. Then, when the app module accesses its own LintMap for the first time it get a map prefilled with the data from the library module, instead of the fresh one.

To demonstrate the issue I created the following setup:

1. An :app module and a :library module;
2. :app module contains app_color color resource, while :library module contains :library_color;
3. I created a simple detector, which works only in partial analysis mode and does a simple thing: detects the color resource declaration within the module, puts into the partial results and then reports all colors found per module in checkPartialResults method;
4. There's a unit test, which mimics the same setup.

If you run lint checks using the ./gradlew :app:lintDebug command, you'll observe Lint correctly reporting app_color found in :app and library_color found in :library. However, if you run the unit tests, you'll observe that Lint also reports a library_color found in the :app.

It looks like while scanning the :app module, the first access to partial results, causes LintCliClient to create new instance of results and fill it with results of the dependent module (see LintCliClient#getPartialResults method). For some reason this is happening only in tests.

The replacement of the getPartialResult.map() method call with getPartialResult.mapFor(context.project) method call successfully addresses the issue.

There's still a chance, that my test is wrong. In this case, would be great to know in which way.

---

Studio Build: Chipmunk | 2021.2.1 Version of Gradle Plugin: 7.2.1, 7.4.0-alpha08 Version of Gradle: 7.4.2 OS: Mac OS Monteray 12.4